WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
277637
[WASM] Unify error messages between typed funcrefs and GC proposals
https://bugs.webkit.org/show_bug.cgi?id=277637
Summary
[WASM] Unify error messages between typed funcrefs and GC proposals
David Degazio
Reported
2024-08-05 10:22:42 PDT
Some of our test expectations currently assume pretty specific error messages for when we pass a JSValue to a typed function reference with an incorrect type, such as "Funcref must be an exported wasm function" if we try to pass a reference to a function that is not a WASM function, or a null to a non-nullable function reference. With the GC proposal, all these reference typing rules are unified, and we generally report a fairly generic error message like "Argument value did not match the reference type" in these cases. I think we should unify these error messages so our tests don't expect different behavior based on if WASM GC is enabled or not, adopting something like the latter "Argument value did not match the reference type" message in all cases.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2024-08-05 10:23:02 PDT
<
rdar://problem/133225789
>
David Degazio
Comment 2
2024-08-06 13:09:04 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/31803
EWS
Comment 3
2024-08-07 10:08:51 PDT
Committed
281942@main
(28d59bbfe713): <
https://commits.webkit.org/281942@main
> Reviewed commits have been landed. Closing PR #31803 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug