Bug 27757 – [commit+] update-webkit-auxiliary-libs, update-webkit-support-libs cause Perl warnings about functions tmpnam and tmpfile

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Daniel Bates]

Perl complains about the functions tmpfile and tmpnam since they are defined in both File::Temp and POSIX. Script that run Perl with warnings enabled (-w flag) show these warnings, such as update-webkit-auxiliary-libs and update-webkit-support-libs.

[Daniel Bates]

Created attachment 33603 [details]
Patch

[Daniel Bates]

Created attachment 33605 [details]
Reduction

A simple example.

When you run this script, say: perl reduction.pl

You should see the following warnings:

Subroutine main::tmpfile redefined at /System/Library/Perl/5.8.8/Exporter.pm line 65.
 at /System/Library/Perl/5.8.8/darwin-thread-multi-2level/POSIX.pm line 19
Subroutine main::tmpnam redefined at /System/Library/Perl/5.8.8/Exporter.pm line 65.
 at /System/Library/Perl/5.8.8/darwin-thread-multi-2level/POSIX.pm line 19

[Eric Seidel (no email)]

Comment on attachment 33603 [details]
Patch

perldoc -f use
says:

               If you do not want to call the package's "import" method (for
               instance, to stop your namespace from being altered), explic-
               itly supply the empty list:

                   use Module ();

               That is exactly equivalent to

                   BEGIN { require Module }


Looks fine.

You might want to add more information to the ChangeLog about why this stops the warning.

[Daniel Bates]

Created attachment 33653 [details]
Patch with updated ChangeLog

Added additional information as per Eric's suggestion.

[Daniel Bates]

Eric, I made the change. Can you land this?

[David Levin]

Comment on attachment 33603 [details]
Patch

Cleared r+ on obsolete patch to move this out of the commit queue.

[Adam Barth]

Comment on attachment 33653 [details]
Patch with updated ChangeLog

Clearing review flag on attachment: 33653

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebKitTools/ChangeLog
	M	WebKitTools/Scripts/update-webkit-auxiliary-libs
	M	WebKitTools/Scripts/update-webkit-support-libs
Committed r46664
	M	WebKitTools/ChangeLog
	M	WebKitTools/Scripts/update-webkit-auxiliary-libs
	M	WebKitTools/Scripts/update-webkit-support-libs
r46664 = 13ac7fcfe92ad91ecbaedb4adecfd2aa9c133cee (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
http://trac.webkit.org/changeset/46664

[Adam Barth]

All reviewed patches have been landed.  Closing bug.