Bug 27757 - [commit+] update-webkit-auxiliary-libs, update-webkit-support-libs cause Perl warnings about functions tmpnam and tmpfile
Summary: [commit+] update-webkit-auxiliary-libs, update-webkit-support-libs cause Perl...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-27 23:28 PDT by Daniel Bates
Modified: 2009-07-31 23:56 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.54 KB, patch)
2009-07-27 23:31 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
Reduction (478 bytes, text/plain)
2009-07-27 23:45 PDT, Daniel Bates 		no flags Details
Patch with updated ChangeLog (1.98 KB, patch)
2009-07-28 10:56 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2009-07-27 23:28:47 PDT 
Perl complains about the functions tmpfile and tmpnam since they are defined in both File::Temp and POSIX. Script that run Perl with warnings enabled (-w flag) show these warnings, such as update-webkit-auxiliary-libs and update-webkit-support-libs.
Comment 1 Daniel Bates 2009-07-27 23:31:40 PDT 
Created attachment 33603 [details]
Patch
Comment 2 Daniel Bates 2009-07-27 23:45:21 PDT 
Created attachment 33605 [details]
Reduction

A simple example.

When you run this script, say: perl reduction.pl

You should see the following warnings:

Subroutine main::tmpfile redefined at /System/Library/Perl/5.8.8/Exporter.pm line 65.
 at /System/Library/Perl/5.8.8/darwin-thread-multi-2level/POSIX.pm line 19
Subroutine main::tmpnam redefined at /System/Library/Perl/5.8.8/Exporter.pm line 65.
 at /System/Library/Perl/5.8.8/darwin-thread-multi-2level/POSIX.pm line 19
Comment 3 Eric Seidel (no email) 2009-07-28 10:37:25 PDT 
Comment on attachment 33603 [details]
Patch

perldoc -f use
says:

               If you do not want to call the package's "import" method (for
               instance, to stop your namespace from being altered), explic-
               itly supply the empty list:

                   use Module ();

               That is exactly equivalent to

                   BEGIN { require Module }


Looks fine.

You might want to add more information to the ChangeLog about why this stops the warning.
Comment 4 Daniel Bates 2009-07-28 10:56:01 PDT 
Created attachment 33653 [details]
Patch with updated ChangeLog

Added additional information as per Eric's suggestion.
Comment 5 Daniel Bates 2009-07-28 23:31:54 PDT 
Eric, I made the change. Can you land this?
Comment 6 David Levin 2009-07-29 00:39:02 PDT 
Comment on attachment 33603 [details]
Patch

Cleared r+ on obsolete patch to move this out of the commit queue.
Comment 7 Adam Barth 2009-07-31 23:56:50 PDT 
Comment on attachment 33653 [details]
Patch with updated ChangeLog

Clearing review flag on attachment: 33653

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebKitTools/ChangeLog
	M	WebKitTools/Scripts/update-webkit-auxiliary-libs
	M	WebKitTools/Scripts/update-webkit-support-libs
Committed r46664
	M	WebKitTools/ChangeLog
	M	WebKitTools/Scripts/update-webkit-auxiliary-libs
	M	WebKitTools/Scripts/update-webkit-support-libs
r46664 = 13ac7fcfe92ad91ecbaedb4adecfd2aa9c133cee (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
http://trac.webkit.org/changeset/46664
Comment 8 Adam Barth 2009-07-31 23:56:54 PDT 
All reviewed patches have been landed.  Closing bug.