Bug 27753 - clean up CSSRuleData in CSSStyleSelector.h
Summary: clean up CSSRuleData in CSSStyleSelector.h
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 49775
  Show dependency treegraph
Reported: 2009-07-27 19:44 PDT by Dirk Pranke
Modified: 2010-12-24 12:44 PST (History)
8 users (show)

See Also:

Patch (4.85 KB, patch)
2010-12-22 17:39 PST, Jan Erik Hanssen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2009-07-27 19:44:09 PDT
CSSRuleData and CSSRuleDataSet don't really need to be in CSSStyleSelector.h (they are only used in the .cpp file). Moving them to the .cpp file will reduce the number of accidental recompiles. In addition, it's possible that CSSRuleDataSet can just be replaced with a std::list container.

(Filed as an offshoot of bug 27748).
Comment 1 Dirk Pranke 2010-04-06 16:37:29 PDT
I'm not working on this now nor do I expect to be in the near future, so I am disclaiming ownership in case someone else wants to pick this up.
Comment 2 Jan Erik Hanssen 2010-12-22 17:39:43 PST
Created attachment 77286 [details]

Move CSSRuleData and CSSRuleDataList from the .h to the .cpp file. Not sure if changing the custom linked list implementation to one of the generic WTF containers is still preferred.
Comment 3 Eric Seidel (no email) 2010-12-24 10:22:47 PST
Comment on attachment 77286 [details]

Seems sane.  There shouldn't be any perf impact if this is the only class using these.
Comment 4 WebKit Commit Bot 2010-12-24 10:54:30 PST
The commit-queue encountered the following flaky tests while processing attachment 77286 [details]:

fast/workers/storage/use-same-database-in-page-and-workers.html bug 50995 (author: dumi@chromium.org)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2010-12-24 10:55:48 PST
Comment on attachment 77286 [details]

Clearing flags on attachment: 77286

Committed r74642: <http://trac.webkit.org/changeset/74642>
Comment 6 WebKit Commit Bot 2010-12-24 10:55:54 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 WebKit Review Bot 2010-12-24 12:40:10 PST
http://trac.webkit.org/changeset/74642 might have broken GTK Linux 32-bit Release
Comment 8 Jan Erik Hanssen 2010-12-24 12:42:47 PST
(In reply to comment #7)
> http://trac.webkit.org/changeset/74642 might have broken GTK Linux 32-bit Release

Seems unlikely to be caused by this.
Comment 9 Eric Seidel (no email) 2010-12-24 12:44:23 PST
They're all media/ test failures from a media change at the same time as this one.  The Gtk bot is kinda slow, so many changes get built at once.