WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
277496
[css-grid] Refactor GridTrackSizingAlgorithm from RenderGrid member to stack-local variable
https://bugs.webkit.org/show_bug.cgi?id=277496
Summary
[css-grid] Refactor GridTrackSizingAlgorithm from RenderGrid member to stack-...
Brandon
Reported
2024-08-01 11:50:18 PDT
Sammy and I had a discussion over the last two days about removing m_trackSizingAlgorithm from RenderGrid.h and refactoring it to inside of layoutGrid and layoutMasonry. This would allow a smaller scope of access to m_trackSizingAlgorithm and ensure that this object only survives during the layout step. Several references to m_trackSizingAlgorithm are called deeply nested inside the layout functions, which would require propagation of object down the function stack.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2024-08-01 11:50:39 PDT
<
rdar://problem/133003009
>
Brandon
Comment 2
2026-02-27 09:28:51 PST
Pull request:
https://github.com/WebKit/WebKit/pull/59583
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug