Bug 27747 - "bugzilla-tool post-commit head" doesn't work because it can't find the bug id from the commit load.
Summary: "bugzilla-tool post-commit head" doesn't work because it can't find the bug i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 27389 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-07-27 18:05 PDT by Pierre d'Herbemont
Modified: 2011-05-24 19:13 PDT (History)
1 user (show)

See Also:

Attachments
2009-07-27 Pierre d'Herbemont <pdherbemont@apple.com> (1.05 KB, patch)
2009-07-27 18:07 PDT, Pierre d'Herbemont 		levin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pierre d'Herbemont 2009-07-27 18:05:37 PDT 
"bugzilla-tool post-commit head" doesn't work because it can't find the bug id from the commit load.

$ WebKitTools/Scripts/bugzilla-tool post-commits head
Traceback (most recent call last):
  File "WebKitTools/Scripts/bugzilla-tool", line 600, in <module>
    main()
  File "WebKitTools/Scripts/bugzilla-tool", line 597, in main
    return tool.main()
  File "WebKitTools/Scripts/bugzilla-tool", line 592, in main
    return command_object.execute(command_options, command_args, self)
  File "WebKitTools/Scripts/bugzilla-tool", line 436, in execute
    bug_id = options.bug_id or commit_message.parse_bug_id()
  File "/Volumes/Data/Sources/WebKit/WebKitTools/Scripts/modules/scm.py", line 84, in parse_bug_id
    match = re.search(Bugzilla.bug_server_regex + "show_bug\.cgi\?id=(?P<bug_id>\d+)", line)
NameError: global name 'Bugzilla' is not defined
Comment 1 Pierre d'Herbemont 2009-07-27 18:07:44 PDT 
Created attachment 33586 [details]
2009-07-27  Pierre d'Herbemont  <pdherbemont@apple.com>

Reviewed by NOBODY (OOPS!).

"bugzilla-tool post-commit head" doesn't work because it can't find the bug id from the commit load.
https://bugs.webkit.org/show_bug.cgi?id=27747

modules.bugzilla is not found because not included.

* Scripts/modules/scm.py: Properly import modules.bugzilla.
---
 2 files changed, 12 insertions(+), 0 deletions(-)
Comment 2 Pierre d'Herbemont 2009-07-27 21:26:42 PDT 
https://trac.webkit.org/changeset/46454
Comment 3 David Kilzer (:ddkilzer) 2009-07-28 16:12:38 PDT 
*** Bug 27389 has been marked as a duplicate of this bug. ***
Comment 4 Eric Seidel (no email) 2009-07-28 16:28:27 PDT 
I think this is the wrong fix.  I don't think scm.py should depend on bugzilla.py.  That said, I think it's OK for now to unbreak things as-is.  There should be some other ChangeLogs.py which knows how to deal with these details.
Comment 5 Eric Seidel (no email) 2009-07-28 16:30:27 PDT 
(Thank you for fixing this though!)