Bug 27747 – "bugzilla-tool post-commit head" doesn't work because it can't find the bug id from the commit load.

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Pierre d'Herbemont]

"bugzilla-tool post-commit head" doesn't work because it can't find the bug id from the commit load.

$ WebKitTools/Scripts/bugzilla-tool post-commits head
Traceback (most recent call last):
  File "WebKitTools/Scripts/bugzilla-tool", line 600, in <module>
    main()
  File "WebKitTools/Scripts/bugzilla-tool", line 597, in main
    return tool.main()
  File "WebKitTools/Scripts/bugzilla-tool", line 592, in main
    return command_object.execute(command_options, command_args, self)
  File "WebKitTools/Scripts/bugzilla-tool", line 436, in execute
    bug_id = options.bug_id or commit_message.parse_bug_id()
  File "/Volumes/Data/Sources/WebKit/WebKitTools/Scripts/modules/scm.py", line 84, in parse_bug_id
    match = re.search(Bugzilla.bug_server_regex + "show_bug\.cgi\?id=(?P<bug_id>\d+)", line)
NameError: global name 'Bugzilla' is not defined

[Pierre d'Herbemont]

Created attachment 33586 [details]
2009-07-27  Pierre d'Herbemont  <[e-mail]>

Reviewed by NOBODY (OOPS!).

"bugzilla-tool post-commit head" doesn't work because it can't find the bug id from the commit load.
https://bugs.webkit.org/show_bug.cgi?id=27747

modules.bugzilla is not found because not included.

* Scripts/modules/scm.py: Properly import modules.bugzilla.
---
 2 files changed, 12 insertions(+), 0 deletions(-)

[Pierre d'Herbemont]

https://trac.webkit.org/changeset/46454

[David Kilzer (:ddkilzer)]

*** Bug 27389 has been marked as a duplicate of this bug. ***

[Eric Seidel (no email)]

I think this is the wrong fix.  I don't think scm.py should depend on bugzilla.py.  That said, I think it's OK for now to unbreak things as-is.  There should be some other ChangeLogs.py which knows how to deal with these details.

[Eric Seidel (no email)]

(Thank you for fixing this though!)