Bug 27745 - fix more obvious global object lookups
Summary: fix more obvious global object lookups
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 27634
  Show dependency tree / graph
 
Reported: 2009-07-27 16:55 PDT by Eric Seidel (no email)
Modified: 2010-02-26 23:11 PST (History)
1 user (show)

See Also:

Attachments
patch (15.23 KB, patch)
2009-07-27 17:01 PDT, Eric Seidel (no email) 		abarth: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-07-27 16:55:50 PDT 
fix more obvious global object lookups

This patch will be the untestable (or at least very difficult to test) prototype lookups.  The remaining pieces of bug 27634 will all need tests.
Comment 1 Eric Seidel (no email) 2009-07-27 17:01:07 PDT 
Created attachment 33582 [details]
patch
Comment 2 Adam Barth 2009-07-27 17:14:49 PDT 
Comment on attachment 33582 [details]
patch

Ok.  The ones that use global execs probably don't have any observable change.  The ones about wrapping the events, you might be able to test with page-created events and synchronous dispatching, but I'm not sure.
Comment 3 Eric Seidel (no email) 2009-07-27 17:21:06 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/bindings/js/JSDOMWindowBase.cpp
	M	WebCore/bindings/js/JSDataGridColumnListCustom.cpp
	M	WebCore/bindings/js/JSEventListener.cpp
	M	WebCore/bindings/js/JSEventTarget.cpp
	M	WebCore/bindings/js/JSHTMLElementCustom.cpp
	M	WebCore/bindings/js/JSHTMLOptionsCollectionCustom.cpp
	M	WebCore/bindings/js/JSLazyEventListener.cpp
	M	WebCore/bindings/js/ScriptController.cpp
	M	WebCore/bindings/js/ScriptEventListener.cpp
	M	WebCore/bindings/js/ScriptObject.cpp
	M	WebCore/bindings/js/ScriptObjectQuarantine.cpp
	M	WebCore/bindings/objc/DOMInternal.mm
Committed r46444
	M	WebCore/ChangeLog
	M	WebCore/bindings/js/ScriptEventListener.cpp
	M	WebCore/bindings/js/JSDataGridColumnListCustom.cpp
	M	WebCore/bindings/js/JSEventListener.cpp
	M	WebCore/bindings/js/ScriptObject.cpp
	M	WebCore/bindings/js/JSHTMLElementCustom.cpp
	M	WebCore/bindings/js/JSLazyEventListener.cpp
	M	WebCore/bindings/js/JSDOMWindowBase.cpp
	M	WebCore/bindings/js/ScriptController.cpp
	M	WebCore/bindings/js/ScriptObjectQuarantine.cpp
	M	WebCore/bindings/js/JSHTMLOptionsCollectionCustom.cpp
	M	WebCore/bindings/js/JSEventTarget.cpp
	M	WebCore/bindings/objc/DOMInternal.mm
r46444 = 8568d33f7c41bbcda2101e2710d3cf1c6f917fa2 (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
http://trac.webkit.org/changeset/46444
Comment 4 Paul Sowden 2010-02-26 23:11:57 PST 
Pretty sure bug 26520 was an observable symptom of this changeset.