WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
27745
fix more obvious global object lookups
https://bugs.webkit.org/show_bug.cgi?id=27745
Summary
fix more obvious global object lookups
Eric Seidel (no email)
Reported
2009-07-27 16:55:50 PDT
fix more obvious global object lookups This patch will be the untestable (or at least very difficult to test) prototype lookups. The remaining pieces of
bug 27634
will all need tests.
Attachments
patch
(15.23 KB, patch)
2009-07-27 17:01 PDT
,
Eric Seidel (no email)
abarth
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1
2009-07-27 17:01:07 PDT
Created
attachment 33582
[details]
patch
Adam Barth
Comment 2
2009-07-27 17:14:49 PDT
Comment on
attachment 33582
[details]
patch Ok. The ones that use global execs probably don't have any observable change. The ones about wrapping the events, you might be able to test with page-created events and synchronous dispatching, but I'm not sure.
Eric Seidel (no email)
Comment 3
2009-07-27 17:21:06 PDT
Committing to
http://svn.webkit.org/repository/webkit/trunk
... M WebCore/ChangeLog M WebCore/bindings/js/JSDOMWindowBase.cpp M WebCore/bindings/js/JSDataGridColumnListCustom.cpp M WebCore/bindings/js/JSEventListener.cpp M WebCore/bindings/js/JSEventTarget.cpp M WebCore/bindings/js/JSHTMLElementCustom.cpp M WebCore/bindings/js/JSHTMLOptionsCollectionCustom.cpp M WebCore/bindings/js/JSLazyEventListener.cpp M WebCore/bindings/js/ScriptController.cpp M WebCore/bindings/js/ScriptEventListener.cpp M WebCore/bindings/js/ScriptObject.cpp M WebCore/bindings/js/ScriptObjectQuarantine.cpp M WebCore/bindings/objc/DOMInternal.mm Committed
r46444
M WebCore/ChangeLog M WebCore/bindings/js/ScriptEventListener.cpp M WebCore/bindings/js/JSDataGridColumnListCustom.cpp M WebCore/bindings/js/JSEventListener.cpp M WebCore/bindings/js/ScriptObject.cpp M WebCore/bindings/js/JSHTMLElementCustom.cpp M WebCore/bindings/js/JSLazyEventListener.cpp M WebCore/bindings/js/JSDOMWindowBase.cpp M WebCore/bindings/js/ScriptController.cpp M WebCore/bindings/js/ScriptObjectQuarantine.cpp M WebCore/bindings/js/JSHTMLOptionsCollectionCustom.cpp M WebCore/bindings/js/JSEventTarget.cpp M WebCore/bindings/objc/DOMInternal.mm
r46444
= 8568d33f7c41bbcda2101e2710d3cf1c6f917fa2 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk
http://trac.webkit.org/changeset/46444
Paul Sowden
Comment 4
2010-02-26 23:11:57 PST
Pretty sure
bug 26520
was an observable symptom of this changeset.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug