Bug 27735 - Give a helpful name to JSLock argument
: Give a helpful name to JSLock argument
Status: RESOLVED FIXED
: WebKit
WebCore JavaScript
: 528+ (Nightly build)
: All All
: P4 Trivial
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2009-07-27 14:25 PST by
Modified: 2009-07-27 16:46 PST (History)


Attachments
proposed patch (123.05 KB, patch)
2009-07-27 14:31 PST, Alexey Proskuryakov
darin: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2009-07-27 14:25:21 PST
JSLock lock(false) just means "shut up JavaScriptCore warnings, we are not working with the legacy JSC API shared global context". We should use a named argument instead of a boolean,
------- Comment #1 From 2009-07-27 14:31:59 PST -------
Created an attachment (id=33570) [details]
proposed patch
------- Comment #2 From 2009-07-27 16:46:38 PST -------
Committed <http://trac.webkit.org/projects/webkit/changeset/46431>.