Bug 27735 - Give a helpful name to JSLock argument
: Give a helpful name to JSLock argument
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript
: 528+ (Nightly build)
: All All
: P4 Trivial
Assigned To: Alexey Proskuryakov
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-07-27 14:25 PDT by Alexey Proskuryakov
Modified: 2009-07-27 16:46 PDT (History)
0 users

See Also:


Attachments
proposed patch (123.05 KB, patch)
2009-07-27 14:31 PDT, Alexey Proskuryakov
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2009-07-27 14:25:21 PDT
JSLock lock(false) just means "shut up JavaScriptCore warnings, we are not working with the legacy JSC API shared global context". We should use a named argument instead of a boolean,
Comment 1 Alexey Proskuryakov 2009-07-27 14:31:59 PDT
Created attachment 33570 [details]
proposed patch
Comment 2 Alexey Proskuryakov 2009-07-27 16:46:38 PDT
Committed <http://trac.webkit.org/projects/webkit/changeset/46431>.