RESOLVED FIXED277334
[web-animations] Physical properties should take priority over logical properties 
https://bugs.webkit.org/show_bug.cgi?id=277334
Summary [web-animations] Physical properties should take priority over logical proper...
Tim Nguyen (:ntim)
Reported 2024-07-30 01:04:30 PDT
See css/css-logical/animation-001.html
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2024-08-06 01:05:17 PDT
<rdar://problem/133278333>
Antoine Quint
Comment 2 2024-08-26 06:25:52 PDT
In the case of "Physical shorthands win over logical shorthands" we fail to compute the correct style for the blending keyframes under Style::Resolver::styleForKeyframe().
Antoine Quint
Comment 3 2024-08-26 07:02:20 PDT
It appears the issue is that we're getting the properties in the wrong order under `Style::Builder::applyLogicalGroupProperties()` where CSSPropertyMarginLeft/CSSPropertyMarginRight are processed prior to CSSPropertyMarginInlineStart/CSSPropertyMarginInlineEnd.
Antoine Quint
Comment 4 2024-08-26 07:08:12 PDT
I expect ElementRuleCollector::addAuthorKeyframeRules() should be in charge of making sure properties are processed in the correct order.
Antoine Quint
Comment 5 2024-08-26 07:28:37 PDT
Or possibly this should be dealt with under `KeyframeEffect::processKeyframes()` assuming this issue is specific to dealing with keyframes provided through the JS API.
Antoine Quint
Comment 6 2024-08-27 06:55:29 PDT
Pull request: https://github.com/WebKit/WebKit/pull/32764
EWS
Comment 7 2024-08-27 13:49:39 PDT
Committed 282815@main (74dcb4aac602): <https://commits.webkit.org/282815@main> Reviewed commits have been landed. Closing PR #32764 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.