Bug 277329 - Fix NetworkRTCMonitor gatherNetworkMap
Summary: Fix NetworkRTCMonitor gatherNetworkMap
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Diego Pino
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-07-29 23:57 PDT by youenn fablet
Modified: 2024-08-01 03:48 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2024-07-29 23:57:09 PDT 
Fix NetworkRTCMonitor gatherNetworkMap
Comment 1 youenn fablet 2024-07-29 23:57:51 PDT 
<rdar://132591641>
Comment 2 youenn fablet 2024-07-30 07:19:39 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/31465
Comment 3 EWS 2024-07-30 16:47:14 PDT 
Committed 281618@main (926c05cb3c2a): <https://commits.webkit.org/281618@main>

Reviewed commits have been landed. Closing PR #31465 and removing active labels.
Comment 4 Diego Pino 2024-08-01 01:43:21 PDT 
Re-opening for pull request https://github.com/webkit/webkit/pull/31590
Comment 5 Diego Pino 2024-08-01 01:44:47 PDT 
There was a build error under Linux:

https://build.webkit.org/#/builders/30/builds/9052

```
/home/buildbot/webkitgtk/nightly/GTK-Linux-64bit-Release-Packaging-Nightly-Ubuntu2004/build/Source/WebKit/NetworkProcess/webrtc/NetworkRTCMonitor.cpp:178:42: error: use of undeclared identifier 'name'
    return rtc::GetAdapterTypeFromName({ name.utf8().data(), name.utf8().length() });
                                         ^
/home/buildbot/webkitgtk/nightly/GTK-Linux-64bit-Release-Packaging-Nightly-Ubuntu2004/build/Source/WebKit/NetworkProcess/webrtc/NetworkRTCMonitor.cpp:178:62: error: use of undeclared identifier 'name'
    return rtc::GetAdapterTypeFromName({ name.utf8().data(), name.utf8().length() });
```
Comment 6 EWS 2024-08-01 03:48:41 PDT 
Committed 281700@main (615df0fc4017): <https://commits.webkit.org/281700@main>

Reviewed commits have been landed. Closing PR #31590 and removing active labels.