Bug 277310 – Missing TypeCastTraits specialization for some SVG element classes

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: SVG

[Fujii Hironori]

Created attachment 472010 [details]
compile errors

While fixing non-unified source build problems, I found out a problem.
Even though SVGFilterElement doesn't have a appropriate TypeCastTraits specialization from SVGElement,
downcast<SVGFilterElement>() is used in RenderSVGResourceFilterInlines.h.
I don't know why unified source build can compile without it.

> C:\webkit\wb\WebKitBuild\Debug\WTF\Headers\wtf/TypeCasts.h(41,23): error: static assertion failed due to requirement 'std::is_void_v<const WebCore::SVGFilterElement>': Missing TypeCastTraits specialization
>    41 |         static_assert(std::is_void_v<ExpectedType>, "Missing TypeCastTraits specialization");
>       |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> C:\webkit\wb\WebKitBuild\Debug\WTF\Headers\wtf/TypeCasts.h(58,63): note: in instantiation of member function 'WTF::TypeCastTraits<const WebCore::SVGFilterElement, const WebCore::SVGElement>::isOfType' requested here
>    58 |     return TypeCastTraits<const ExpectedType, const ArgType>::isOfType(source);
>       |                                                               ^
> C:\webkit\wb\WebKitBuild\Debug\WTF\Headers\wtf/TypeCasts.h(96,20): note: in instantiation of function template specialization 'WTF::is<WebCore::SVGFilterElement, WebCore::SVGElement>' requested here
>    96 |     RELEASE_ASSERT(is<Target>(source));
>       |                    ^
> C:\webkit\wb\Source\WebCore\rendering\svg\RenderSVGResourceFilterInlines.h(36,12): note: in instantiation of function template specialization 'WTF::downcast<WebCore::SVGFilterElement, WebCore::SVGElement>' requested here
>    36 |     return downcast<SVGFilterElement>(RenderSVGResourceContainer::element());
>       |            ^

There are similar problems in the following classes:
 - SVGFilterElement
 - SVGFEFloodElement
 - SVGFEDropShadowElement
 - SVGFEDiffuseLightingElement
 - SVGFESpecularLightingElement
 - SVGPathElement

[Fujii Hironori]

Ah, they are defined in SVGElementTypeHelpers.h in DerivedSources.

[Fujii Hironori]

*** This bug has been marked as a duplicate of bug 277306 ***