Bug 27731 - [V8] Implement EventListener::reportError for V8 event listeners in worker context.
Summary: [V8] Implement EventListener::reportError for V8 event listeners in worker co...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Jian Li
URL: h
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-27 13:30 PDT by Jian Li
Modified: 2009-07-27 18:12 PDT (History)
1 user (show)

See Also:

Attachments
Proposed Patch (3.95 KB, patch)
2009-07-27 13:35 PDT, Jian Li 		levin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jian Li 2009-07-27 13:30:13 PDT 
Implement EventListener::reportError for V8 event listeners in worker context.
Comment 1 Jian Li 2009-07-27 13:35:19 PDT 
Created attachment 33567 [details]
Proposed Patch
Comment 2 David Levin 2009-07-27 18:04:19 PDT 
Comment on attachment 33567 [details]
Proposed Patch


> diff --git a/WebCore/bindings/v8/V8WorkerContextEventListener.cpp b/WebCore/bindings/v8/V8WorkerContextEventListener.cpp
> +    // The callback function on XMLHttpRequest can clear the event listener and destroys 'this' object. Keep a local reference to it.

I'd get rid of "on XMLHttpRequest" and change "destroys" to "destroy".


> +    // See issue 889829.

I'd remove this issue number here.
Comment 3 Jian Li 2009-07-27 18:12:18 PDT 
Committed as http://trac.webkit.org/changeset/46448