WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
277292
Remove unused member of CanvasGradient
https://bugs.webkit.org/show_bug.cgi?id=277292
Summary
Remove unused member of CanvasGradient
Said Abou-Hallawa
Reported
2024-07-29 16:09:24 PDT
217831@main
added the new member m_canvas which has the type CanvasBase& to CanvasGradient. This member was used to parseColor() in CanvasGradient::addColorStop().
251207@main
replaced m_canvas by a new member m_context which has the type Ref<CanvasRenderingContext>.
263774@main
changed the type of m_context to be WeakPtr<CanvasRenderingContext>
279017@main
removed the use of m_context when calling parseColor(). So CanvasGradient currently does not have any use to m_context.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2024-07-29 16:09:42 PDT
<
rdar://problem/132761528
>
Said Abou-Hallawa
Comment 2
2024-07-29 16:20:20 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/31419
EWS
Comment 3
2024-07-30 10:07:39 PDT
Committed
281575@main
(b8296c22c6a6): <
https://commits.webkit.org/281575@main
> Reviewed commits have been landed. Closing PR #31419 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug