Transformations have CSS values of DOMCSSValueList, not DOMWebkitCSSTransformationValue

[Andy Matuschak]

Created attachment 33561 [details]
Test case demonstrating the problem

Overview:
To parse a -webkit-transform property, the developer needs to be able to determine the types of transformations described within (translation, rotation, etc). There are definitions for an DOMWebkitCSSTransformationValue interface that would provide for this, but they're never actually provided by the DOM when queried.

I'm encountering this problem when using Obj-C bindings, so it's possible that when queried via JS, this doesn't happen.

Steps to reproduce:
1. Call getPropertyCSSValue("-webkit-transform") on an element with a transformation.
2. Examine the CSSValueList returned, note the type of each item.

Actual results:
The items are CSSValueLists.

Expected results:
The items should be WebkitCSSTransformationValues.

See attached test case.

[Simon Fraser (smfr)]

kitClass(WebCore::CSSValue* impl) in DOMCSS.mm needs to be educated about different types of CSSValueLists, but I'm not sure if we should expand the list of CSSValue types in CSSValue.idl. It looks like this same problem would occur with CSSTimingFunctionValue, CSSUnicodeRangeValue, CSSBorderImageValue, CSSFontFaceSrcValue, CSSFunctionValue, CSSImageGeneratorValue, CSSReflectValue etc etc.

[Simon Fraser (smfr)]

Dave Hyatt says to add a new CSSValueType for CSSTransformationValue

[Simon Fraser (smfr)]

Created attachment 38760 [details]
Patch

[Mark Rowe (bdash)]

Comment on attachment 38760 [details]
Patch

r=me

[Simon Fraser (smfr)]

http://trac.webkit.org/changeset/47877

[Simon Fraser (smfr)]

Test added in http://trac.webkit.org/changeset/47901