Bug 277206 - [Ruby] Add initial parsing support for ruby-align
Summary: [Ruby] Add initial parsing support for ruby-align
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks: ruby-align
  Show dependency tree / graph
 
Reported: 2024-07-27 08:06 PDT by zalan
Modified: 2024-07-28 20:05 PDT (History)
15 users (show)

See Also:

Attachments
Patch (19.38 KB, patch)
2024-07-27 08:09 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (31.45 KB, patch)
2024-07-27 13:08 PDT, zalan 		no flags Details | Formatted Diff | Diff
[fast-cq]Patch (33.69 KB, patch)
2024-07-28 17:31 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2024-07-27 08:06:25 PDT 
ssia
Comment 1 zalan 2024-07-27 08:09:59 PDT 
Created attachment 471982 [details]
Patch
Comment 2 zalan 2024-07-27 13:08:02 PDT 
Created attachment 471985 [details]
Patch
Comment 3 Tim Nguyen (:ntim) 2024-07-28 10:18:27 PDT 
Comment on attachment 471985 [details]
Patch

LGTM, you'll want to update LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt as well
Comment 4 Tim Nguyen (:ntim) 2024-07-28 10:20:29 PDT 
Comment on attachment 471985 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=471985&action=review

> Source/WebCore/css/CSSProperties.json:5504
> +            "status": "in development"

We often forget to keep the status up-to-date fwiw, please don't forget to remove it once it's done!
Comment 5 Tim Nguyen (:ntim) 2024-07-28 10:21:04 PDT 
Comment on attachment 471985 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=471985&action=review

> COMMIT_MESSAGE:9
> +* LayoutTests/imported/w3c/web-platform-tests/css/css-ruby/inheritance-expected.txt:
> +* LayoutTests/imported/w3c/web-platform-tests/css/css-ruby/parsing/ruby-align-valid-expected.txt:

nit: Changelog needs updating with all the rebaselines
Comment 6 zalan 2024-07-28 17:31:02 PDT 
Created attachment 471993 [details]
[fast-cq]Patch
Comment 7 EWS 2024-07-28 20:04:48 PDT 
Committed 281478@main (aa7652f60c38): <https://commits.webkit.org/281478@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 471993 [details].
Comment 8 Radar WebKit Bug Importer 2024-07-28 20:05:16 PDT 
<rdar://problem/132694293>