WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
277089
[WASM] Prefixed opcodes should be printed in full in code origins and disassembly
https://bugs.webkit.org/show_bug.cgi?id=277089
Summary
[WASM] Prefixed opcodes should be printed in full in code origins and disasse...
David Degazio
Reported
2024-07-25 12:25:02 PDT
Our WASM disassembly and code origins assume that each WASM instruction is identifiable by a single OpType. This hasn't been true for a while, and what this means is whenever we dump the origin for a SIMD or GC or Ext1 opcode, we just dump something like "ExtGC" instead of something more specific. We should pass this information along when it's easily possible to aid in debugging.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2024-07-25 12:25:16 PDT
<
rdar://problem/132508220
>
David Degazio
Comment 2
2024-07-25 12:56:15 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/31239
David Degazio
Comment 3
2024-07-25 14:14:39 PDT
Example --dumpBBQDisassembly=1 output before: [ 0x1] ExtSIMD [ 0x13] ExtSIMD [ 0x25] ExtSIMD [ 0x28] ExtSIMD [ 0x2b] End ...and after: [ 0x1] V128Const [ 0x13] V128Const [ 0x25] F32x4Pmin [ 0x28] F32x4ExtractLane [ 0x2b] End
EWS
Comment 4
2024-07-26 14:36:23 PDT
Committed
281418@main
(d898a3cffd9c): <
https://commits.webkit.org/281418@main
> Reviewed commits have been landed. Closing PR #31239 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug