I've finished my current audit of the bindings for isolated world issues. The last thing I found in this class is ScheduledAction::execute, which needs to know how to call back its m_function in the proper world.
We want OwnHandle from 27533 and the new V8Proxy::context(Frame*) from 27701 before implementing this fix. The fix looks really.
Note: I would prefer that setTimeout(<string>) from an isolated world executes in the isolated world. My view on the situation is: - eval(), setTimeout(<string>): execute in isolated world - append script tag, location.href = "javascript:": execute in main world
Created attachment 33705 [details] Work-in-progress
Created attachment 33959 [details] Patch v1
Sorry this took so long. I ran into a nasty test_shell bug that confused me for a long time. We'll need to land http://codereview.chromium.org/159782 before these tests will pass downstream.
Comment on attachment 33959 [details] Patch v1 The test_shell change downstream is wrong. I'm not sure how to get the testing harness to run the tests properly.... :(
Created attachment 33993 [details] Patch v1
The new plan is to change test_shell to evaluate the isolated script immediately instead of using the work_queue_. That simplifies life dramatically. I've changed the patch to rename "queueScriptInIsolatedWorld" to "evaluateScriptInIsolateWorld" to indicate that this call is now synchronous.
Comment on attachment 33993 [details] Patch v1 These are two separate changes. 1. to change queue to evaluate. 2. to fix ScheduledAction. I don't really know what this does, but I trust you do: 51 m_context.makeWeak(); These changes look both fine, but should be split into two.
Created attachment 34113 [details] Rename queueScriptInIsolatedWorld --- 18 files changed, 47 insertions(+), 17 deletions(-)
Created attachment 34114 [details] Scheduled action --- 10 files changed, 129 insertions(+), 18 deletions(-)
Comment on attachment 34113 [details] Rename queueScriptInIsolatedWorld LGTM. I assume this has a corresponding change in Chromium's test_shell?
Comment on attachment 34114 [details] Scheduled action LGTM.
Assigned for landing. Landing this is a tricky dance.
Comment on attachment 34113 [details] Rename queueScriptInIsolatedWorld Landed the first patch in http://trac.webkit.org/changeset/46794
http://trac.webkit.org/changeset/46838
I had to back this out a while ago.
Created attachment 39414 [details] Patch v1
Comment on attachment 39414 [details] Patch v1 I didn't know this until recently, but "explicit" is only needed for single-argument constructors: 50 explicit ScheduledAction(v8::Handle<v8::Context> context, const WebCore::String& code, const KURL& url = KURL())
(In reply to comment #19) > I didn't know this until recently, but "explicit" is only needed for > single-argument constructors: Yeah, I actually removed the keyword in an earlier iteration of this patch, but must have lost that diff at some point. I can remove it on landing.
Comment on attachment 39414 [details] Patch v1 r=me, with nits. > +function done() { Brace on new line here and on. > + if (window.layoutTestController) > + layoutTestController.notifyDone(); 4 space indent here and on.
Comment on attachment 39414 [details] Patch v1 Marking cq- so I can fix the nits. Thanks for the review.
Committed r48455: <http://trac.webkit.org/changeset/48455>
Patch partially rolled out in http://trac.webkit.org/changeset/48483, after we started seeing crashes in V8Proxy::retrieveFrameForEnteredContext(), like these: chrome_23a0000!v8::internal::Context::global_context+0x3f [c:\b\slave\chromium-rel-xp\build\src\v8\src\contexts.cc @ 59] chrome_23a0000!v8::internal::Context::global_proxy+0x5 [c:\b\slave\chromium-rel-xp\build\src\v8\src\contexts.cc @ 66] chrome_23a0000!v8::Context::Global+0x52 [c:\b\slave\chromium-rel-xp\build\src\v8\src\api.cc @ 2746] chrome_23a0000!WebCore::V8Proxy::retrieveWindow+0x13 [c:\b\slave\chromium-rel-xp\build\src\third_party\webkit\webcore\bindings\v8\v8proxy.cpp @ 504] chrome_23a0000!WebCore::V8Proxy::retrieveFrameForEnteredContext+0x22 [c:\b\slave\chromium-rel-xp\build\src\third_party\webkit\webcore\bindings\v8\v8proxy.cpp @ 526] chrome_23a0000!WebCore::ScriptController::processingUserGesture+0xe [c:\b\slave\chromium-rel-xp\build\src\third_party\webkit\webcore\bindings\v8\scriptcontroller.cpp @ 138] chrome_23a0000!WebCore::FrameLoader::requestFrame+0xf6 [c:\b\slave\chromium-rel-xp\build\src\third_party\webkit\webcore\loader\frameloader.cpp @ 432] chrome_23a0000!WebCore::HTMLFrameElementBase::openURL+0x8f [c:\b\slave\chromium-rel-xp\build\src\third_party\webkit\webcore\html\htmlframeelementbase.cpp @ 106] chrome_23a0000!WebCore::HTMLFrameElementBase::setLocation+0xab [c:\b\slave\chromium-rel-xp\build\src\third_party\webkit\webcore\html\htmlframeelementbase.cpp @ 212]
Is there some way I can reproduce the crashes locally? The LayoutTests seem to run fine on the buildbot...
Here's a sample (copy/paste from chrome crash bot): http://vietnamnet.vn/chinhtri/ - (details) (dump) (trace) http://register.paltalk.com/reg/landing_pagc123.jsp - (details) (dump) (trace) http://www.elsuperpolvo.com/ - (details) (dump) (trace) http://www.time.com/time/politics - (details) (trace) http://elgarbanzo.com/ - (details) (trace) http://cercalavoro.monster.it/ - (details) (trace) http://pc.watch.impress.co.jp/docs/2008/1111/netbook08.htm - (details) (dump) (trace) http://www.paltalk.com/search/webapp/search/groups/SearchGroups.wmt - (details) (trace) http://home.napster.com/collection_sync.html - (details) (trace) http://www.peachjohn.co.jp/shop/window.php - (details) (trace) http://barbie.everythinggirl.com/activities/fashion/makeover/ - (details) (trace) http://dc.watch.impress.co.jp/cda/review/2008/11/06/9544.html - (details) (trace) http://jobsearch.monster.ca/ - (details) (trace) http://www.wawerko.de/index.php - (details) (trace) http://www.skype.com/intl/en-gb/allfeatures/subscriptions/ - (details) (trace) http://www.dmax.de/tv-programm/ - (details) (trace) http://pc.watch.impress.co.jp/docs/2008/1110/hot580.htm - (details) (dump) (trace) http://barbie.everythinggirl.com/diamond/ - (details) (trace) http://blog.sina.com.cn/s/blog_4ac5b19f0100ba3g.html - (details) (dump) (trace) http://www.adultswim.com/video/index.html - (details) (trace) http://my.aol.com/# - (details) (trace) http://mail73.abv.bg/app/j/box.jsp - (details) (dump) (trace) http://www.barceloviajes.com/sites/all/vuelos/disponibilidad.jsp - (details) (dump) (trace) http://monster.de/ - (details) (dump) (trace) http://blog.sina.com.cn/s/blog_46e815bb0100bcgm.html - (details) (dump) (trace) http://www.tomshardware.com/us/#redir - (details) (dump) (trace) http://tw.search.bid.yahoo.com/search/booth - (details) (dump) (trace) http://blog.sina.com.cn/s/blog_47014d300100ax71.html - (details) (trace) http://shop.ebay.com.au/items/ - (details) (dump) (trace) http://www.theitjobboard.co.uk/index.php - (details) (trace) http://www.goalsarena.com/ - (details) (trace) http://pt.betclic.com/sport/EventDetail.aspx - (details) (trace) http://www43.ownskin.com/theme - (details) (trace) http://pbskids.org/curiousgeorge/printables/ - (details) (dump) (trace) http://www.asus.com.tw/products.aspx - (details) (trace) http://hp-consumer.my.aol.ch/ - (details) (dump) (trace) http://www.mature-bitches.com/galleries/mycats2/maturewives.shtml - (details) (trace) http://www.soldados.com/plazas/buscador.jsp - (details) (dump) (trace) http://compaq-consumer.my.aol.es/ - (details) (trace) http://www.cuantosexo.com/media/profesora-caliente.html - (details) (trace) http://pc.watch.impress.co.jp/docs/2008/1113/hotrev387.htm - (details) (trace) http://www.holidaycheck.at - (details) (trace) http://www.fotolog.com - (details) (dump) (trace) http://www.adultswim.com/games/ - (details) (dump) (trace) http://www.drapt.com/maemul/index.htm - (details) (trace) http://www.quizilla.com/my/watchlist - (details) (trace) http://hp-consumer.my.aol.com.br/ - (details) (dump) (trace) http://hp-consumer.my.aol.ca/ - (details) (trace) http://www.spielesite.com/# - (details) (dump) (trace) http://xxxstash.com/action/videolist/videonew/ - (details) (trace) http://www.bluemountain.com/downloads/category.pd - (details) (trace) http://www.bluemountain.com/display.pd - (details) (dump) (trace) http://www.noordhollandsdagblad.nl/ - (details) (trace) http://www.protv.ro/ - (details) (dump) (trace) http://www.swissarmy.com/multitools/Pages/Category.aspx - (details) (trace) http://www.rootzoo.com/threads/browse - (details) (dump) (trace) http://pc.watch.impress.co.jp/docs/2008/1107/winhec02.htm - (details) (dump) (trace) http://www.watch.impress.co.jp/game/docs/20081110/fallout3.htm - (details) (dump) (trace) http://paxacu.com.mx/home/index.php - (details) (trace) http://www.moviemaze.de/media/trailer/ - (details) (trace) http://blog.sina.com.cn/s/blog_3de20b180100bfk6.html - (details) (trace) http://www.mobango.com/swarea/ - (details) (dump) (trace) http://www.ilgiornale.it/video.pic1 - (details) (dump) (trace) http://www.sukuposti.net/results.php - (details) (dump) (trace) http://www.monster.co.uk/ - (details) (trace) http://www.littlewoodsdirect.com/rf/lxd/navigation/home/index.do - (details) (dump) (trace) http://www.usmarkets.nl/Categorien/Beurs-round-up.44.html - (details) (dump) (trace) http://www.pointcafe.jp/ - (details) (dump) (trace) http://k-tai.impress.co.jp/cda/article/stapa/42694.html - (details) (trace) http://pc.watch.impress.co.jp/docs/2008/1112/jisho025.htm - (details) (trace) http://www.monster.it/ - (details) (trace) http://mark.sina.com.cn/v2/blog_hot.php?hwfrom=浪首_博客区&keyword=柳屹:无上装大片&url=http://blog.sina.com.cn/s/blog_3e42c9950100bk4a.html?tj=1 - (details) (dump) (trace) http://www.vi.nl/Wedstrijden/Wedstrijd.htm - (details) (trace) http://mail73.abv.bg/app/servlet/plogin - (details) (dump) (trace) http://www.adultswim.com/games/index.html - (details) (trace) http://en.betclic.com/sport/EventDetail.aspx - (details) (dump) (trace) http://www.iex.nl/stocks/stocks_detail.asp - (details) (trace) http://www.peachjohn.co.jp/shop/desc.php - (details) (dump) (trace) http://www.tucoff.com/cgi-bin/atx/out.cgi - (details) (dump) (trace) http://en.betclic.com/sport/Match.aspx - (details) (trace) http://www.irshell.org/site/index.php - (details) (trace) http://www.hotfm.com.my/ - (details) (trace) http://www.xperienciasxtremas.com/index.php - (details) (dump) (trace) http://www.ngfotocommunity.net/index.php - (details) (dump) (trace) http://www.quizilla.com/quizzes - (details) (dump) (trace) http://vietnamnet.vn/thegioi/ - (details) (dump) (trace) http://www.web-modules.net/userbar.html - (details) (trace) http://www.quizilla.com/stories/popular - (details) (trace) http://www.tbs.com/video/index/#/all-video/full-episodes/ - (details) (trace) http://mon.monster.fr/account/accountedit.aspx - (details) (trace) http://pc.watch.impress.co.jp/docs/2008/1107/asus.htm - (details) (trace) http://www.kingsvideos.com/ - (details) (trace) http://frontpage.fok.nl/ - (details) (dump) (trace) http://www.bluemountain.com/cnp/cpselect.pd - (details) (trace) http://www.jaap.nl/huizen/ - (details) (dump) (trace) http://www.homescandal.com/home/ - (details) (trace) http://www.pandora.com/backstage - (details) (dump) (trace) http://aukcje.nasza-klasa.pl/ - (details) (trace) http://www.lasenza.com/eng/categorysearch/redirect.cfm - (details) (trace) http://www.alquds.com/pdf - (details) (dump) (trace) http://boards.adultswim.com/adultswim/board - (details) (dump) (trace) http://shop.plaza.rakuten.co.jp/ - (details) (trace) http://www53.ownskin.com/theme - (details) (trace) http://box.zhangmen.baidu.com/m?gate=5&ct=134217728&tn=baidumt,未选择歌曲%20%20&word=mp3,,,[]&si=;;未选择歌曲;;;;&lm=16777216 - (details) (trace) http://vietnamnet.vn/kinhte/ - (details) (trace) http://www.tmf.nl/ - (details) (dump) (trace) http://www.bdd.cl/ - (details) (dump) (trace) http://hlo.tohotheater.jp/net/schedule/010/TNPI2000J01.do - (details) (dump) (trace) http://hp-consumer.my.aol.it/ - (details) (trace) http://www.weeronline.nl/nlnlaaz.htm - (details) (trace) http://blog.sina.com.cn/s/blog_4758d0dd0100bdm4.html - (details) (dump) (trace) http://www.quizilla.com/quizzes/ultimate - (details) (dump) (trace) http://av.watch.impress.co.jp/docs/20081112/sharp.htm - (details) (dump) (trace) http://hp-commercial.my.aol.com/ - (details) (trace) http://www.usmarkets.nl/ - (details) (dump) (trace) http://blog.sina.com.cn/s/blog_4a39b61b0100bilk.html - (details) (trace) http://hp-consumer.my.aol.de/ - (details) (dump) (trace) http://www.lasenza.com/fre/categorysearch/redirect.cfm - (details) (trace) http://partsfinder.ebay.co.uk/#tyres/vrm - (details) (trace) http://shop.paulfrank.com/store/productslist.aspx - (details) (trace) http://www.newson6.com/ - (details) (trace) http://www.babnet.net/ - (details) (trace) http://compaq-consumer.my.aol.co.uk/ - (details) (trace) http://k-tai.impress.co.jp/cda/article/news_toppage/42606.html - (details) (trace) http://www.quizilla.com/my/profile - (details) (dump) (trace) http://www.clubic.com/download/ - (details) (dump) (trace) http://hp-consumer.my.aol.qc.ca/ - (details) (trace) http://www.eurobench.com/ - (details) (trace) http://hp-commercial.my.aol.co.uk/ - (details) (dump) (trace) http://my.monster.com/home.aspx - (details) (trace) http://www.watch.impress.co.jp/game/docs/20081107/r2.htm - (details) (dump) (trace) http://www.skype.com/go/subscriptions - (details) (trace) http://www.qunar.com/site/index.htm - (details) (trace) http://www.iex.nl/# - (details) (dump) (trace) http://www.360buy.com/brandlist.aspx - (details) (dump) (trace) http://mail72.abv.bg/app/j/logout.jsp - (details) (dump) (trace) http://www.jiwa.fm/ - (details) (trace) http://blog.sina.com.cn/s/blog_4a39b61b0100bikd.html - (details) (dump) (trace) http://www.time.com/time/ - (details) (trace) http://usa.asus.com/products.aspx - (details) (dump) (trace) http://france.asus.com/products.aspx - (details) (dump) (trace) http://mail72.abv.bg/app/j/openmessage.jsp - (details) (trace) http://www.time.com/time/politics/article/0,8599,1856613,00.html - (details) (trace) http://stockgroup.financialpost.com/sn_overview_fp.asp - (details) (trace) http://www.babes-board.ch/babelist/ - (details) (dump) (trace) http://www.hautelook.com/product - (details) (trace) http://pc.watch.impress.co.jp/docs/2008/1110/transcend.htm - (details) (trace) http://blog.sina.com.cn/s/blog_47465aa50100bgyx.html - (details) (trace) http://ibe.s7.ru/S7/webqtrip.html - (details) (trace) http://www.worldofwarcraft.com/downloads/wallpapers/fan-wallpapers/ - (details) (trace) http://www.dagbladet.no/tegneserie/ - (details) (trace) http://www.time.com/time/nation/article/0,8599,1857980,00.html - (details) (trace) http://www.enjoy.se/prodlist.php - (details) (trace) http://www.visiofoot.fr/ - (details) (dump) (trace) http://offer.mobistar.be/fr/promotions/promo-tempomusic - (details) (trace) http://www.skynet.be/entertainment-fr/dossier - (details) (dump) (trace) http://blog.sina.com.cn/s/blog_4ca2560d0100bl3h.html - (details) (trace) http://www.alljobs.co.il/home.aspx - (details) (dump) (trace) http://pc.watch.impress.co.jp/docs/2008/1112/asus.htm - (details) (trace) http://k-tai.impress.co.jp/cda/article/news_toppage/42595.html - (details) (trace) http://pl.betclic.com/Sport/live.aspx - (details) (trace) http://www.zarplata.ru/user/applicant/resume/index.aspx - (details) (dump) (trace) http://www.capital.com.tw/ - (details) (trace) http://pc.watch.impress.co.jp/docs/2008/1110/yajiuma.htm - (details) (dump) (trace) http://mystock.cn.yahoo.com/mystock/mystock.html - (details) (dump) (trace) http://www.enwhore.com/movie/18316-Chunky-Teen-Gets-Her-Pussy-Fucked-Good.html - (details) (trace) http://pc.watch.impress.co.jp/docs/2008/1111/pa_cphdd.htm - (details) (dump) (trace) http://www.kcrw.com/ - (details) (trace) http://www.wickedtemptations.com/lingerie-categories-best-sellers.html - (details) (dump) (trace) http://www.o-books.com/marketing/index.php - (details) (trace) http://www.cumpool.com/cgi-bin/atx/out.cgi - (details) (trace) http://my.barackobama.com/page/content/espanol - (details) (trace) http://fotolog.com/ - (details) (trace) http://www.zorraspilladas.com/ - (details) (trace) http://dc.watch.impress.co.jp/cda/other/2008/11/11/9611.html - (details) (trace) http://www.carpartswholesale.com/v5/models.php - (details) (dump) (trace) http://www.quizilla.com/my/message/compose - (details) (trace) http://www.klm.com/travel/gb_en/index_default.html - (details) (trace) http://www.radioparty.ro/index.php - (details) (trace) http://www.edhardyshop.com/ - (details) (dump) (trace) http://www.scholieren.com/ - (details) (trace) http://www.quizilla.com/search - (details) (trace) http://www.animenewsnetwork.com/encyclopedia/anime.php - (details) (trace) http://www.stylintrucks.com/sn.aspx - (details) (trace) http://irshell.org/site/index.php - (details) (trace) http://boards.adultswim.com/adultswim/ - (details) (dump) (trace) http://usa.asus.com/index.aspx - (details) (trace) http://www.routenet.nl/ - (details) (trace) http://www.asus.com/index.aspx - (details) (dump) (trace) http://cfrb.lecpoints.com/index.php - (details) (trace) http://uk.asus.com/products.aspx - (details) (dump) (trace) http://my.monster.it/login.aspx - (details) (trace) http://www.skype.com/intl/pl/allfeatures/subscriptions/ - (details) (trace) http://mail73.abv.bg/app/j/home.jsp - (details) (trace) http://www.pointclickhome.com/sweepstakes - (details) (dump) (trace) http://cmsgallery.naughtyamerica.com/tour/2cst/558/690/2/TC_11_03/mm_01/ - (details) (dump) (trace) http://tienda.vodafone.es/moviles/lanzamientos/blackberry_storm/index.jsp - (details) (trace) http://www.alljobs.co.il/ - (details) (trace) http://www.teenvogue.com/style/bestdressed/teen-vogue-best-dressed-october-2008 - (details) (trace) http://my.monster.com/Account/ApplyHistory.aspx - (details) (dump) (trace) http://www.authorize.net/ - (details) (trace) http://www.rossoincontri.com/modules/rmmf/view.php - (details) (trace) http://www.skype.com/intl/it/allfeatures/subscriptions/ - (details) (trace) http://www.hokuseiyoichi.com/ - (details) (trace) http://www.nokia.com.br/ - (details) (trace) http://h8m.net/browse.php - (details) (dump) (trace) http://my.monster.com/Login.aspx - (details) (dump) (trace) http://www.monster.com/ - (details) (dump) (trace) http://www.mobango.com/swarea/index.php/games/f-most_viewed - (details) (trace) http://www.skype.com/intl/es/allfeatures/subscriptions/ - (details) (trace) http://www.nokia.it/A41096547 - (details) (trace) http://www.muivi.com/muivi/index.php - (details) (dump) (trace) http://www.skynet.be/services/recherche/google - (details) (trace) http://www.mangmoo.com/board/index.php - (details) (trace) http://www.abeltronica.com/velocimetro/pt/ - (details) (dump) (trace) http://www.adultswim.com/index2.html - (details) (dump) (trace) http://www.cafejeux.com/#game/7 - (details) (trace) http://www.pwonline.ru/account.php - (details) (dump) (trace) http://www.cafejeux.com/ - (details) (trace) http://v.vodone.com/content_2008.shtml - (details) (dump) (trace) http://www.cafejeux.com/# - (details) (trace) http://fr.asus.com/products.aspx - (details) (dump) (trace) http://n5f.info/browse.php - (details) (trace) http://www.skype.com/allfeatures/subscriptions/ - (details) (trace) http://www.mature-bitches.com/galleries/veryoldgranny.shtml - (details) (dump) (trace) http://www.xiaoli.cc/ - (details) (trace) http://www.emerce.nl/ - (details) (trace) http://www.iex.nl/ - (details) (trace) http://www.direttagoal.it/ - (details) (dump) (trace) http://www.peachjohn.co.jp/ - (details) (trace) http://www.greenshines.com/ - (details) (trace) http://www27.ownskin.com/theme - (details) (dump) (trace) http://www.sesso24ore.com/ - (details) (trace) http://tw.search.bid.yahoo.com/search/ac - (details) (trace) http://www.skype.com/intl/ja/allfeatures/subscriptions/ - (details) (trace) http://www.cfares.com/advancedsearch.cfr - (details) (trace) http://www.funx.nl/index.php - (details) (trace) http://k-tai.impress.co.jp/cda/article/news_toppage/42688.html - (details) (dump) (trace) http://radiozet.allegro.pl/showcat.php - (details) (trace) http://dc.watch.impress.co.jp/cda/dslr/2008/11/08/9440.html - (details) (trace) http://www.camelclips.com/ - (details) (dump) (trace) http://www.atrapalo.com/espectaculos/madrid - (details) (trace) http://compaq-consumer.my.aol.ca/ - (details) (dump) (trace) http://www.foxwoods.com/ - (details) (dump) (trace) http://www.wickedtemptations.com/ - (details) (trace) http://www.fujiya-camera.co.jp/ - (details) (trace) http://www.blondinbella.se/ - (details) (trace) http://blog.sina.com.cn/s/blog_4d89b8340100b8hi.html - (details) (trace) http://www.stltoday.com/sports#stl-masthead - (details) (trace) http://port.ro/pls/fi/films.film_page - (details) (trace) http://amapy.atlas.cz/default.aspx - (details) (dump) (trace) http://www.mcdonalds.co.jp/shop/index.html - (details) (dump) (trace) http://www.athleticum.ch/shop/products/index.html - (details) (trace) http://www.scholieren.com/zoeken - (details) (trace) http://www.funx.nl/ - (details) (trace) http://www.peachjohn.co.jp/digicata/ - (details) (trace) http://www.fuse.tv/music/best-of-2008/ - (details) (trace) http://www.kathimerini.gr/ - (details) (dump) (trace) http://www.ukb-kvcd.com/forums/index.php - (details) (trace) http://www.diez.hn/ - (details) (trace) http://www.vesseltracker.com/app - (details) (dump) (trace) http://www.ziekenhuis.nl/index.php - (details) (trace) http://forum.scholieren.com/showthread.php - (details) (dump) (trace) http://mein.monster.de/Resume/ViewResume.aspx - (details) (dump) (trace) http://www.xxxmofo.com/ - (details) (trace)
Awesome. Thanks. I'll investigate this weekend.
Comment on attachment 39414 [details] Patch v1 Clearing flags while investigating the crash.
Reduction: <script> function log(msg) { var elmt = document.createElement("div"); elmt.textContent = msg; document.body.appendChild(msg); } var timer = setInterval(function() { clearInterval(timer); log("fired"); }, 10); </script> Maybe it has to do with the clearInterval making us delete something we actually need.
Created attachment 40101 [details] Patch v1
Dimitri, you should be excited to review this patch because it fixes two LayoutTests!
Comment on attachment 40101 [details] Patch v1 If I was any more excited, I would burst into confetti-sized pieces, District 9-style. r=me.
Comment on attachment 40101 [details] Patch v1 Clearing flags on attachment: 40101 Committed r48759: <http://trac.webkit.org/changeset/48759>
All reviewed patches have been landed. Closing bug.
Comment on attachment 40101 [details] Patch v1 > +++ b/LayoutTests/fast/dom/timer-clear-interval-in-handler-and-generate-error.html > +function log(msg) { > + var elmt = document.createElement("div"); > + elmt.textContent = msg; > + document.body.appendChild(msg); Should this be "document.body.appendChild(elmt);"?
> Should this be "document.body.appendChild(elmt);"? Probably. Would you like to create a new bug and post a patch for this?
(In reply to comment #36) > > Should this be "document.body.appendChild(elmt);"? > > Probably. Would you like to create a new bug and post a patch for this? Made Bug#33649