Bug 27702 - [Qt] Buildfix on Windows
Summary: [Qt] Buildfix on Windows
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2009-07-27 02:11 PDT by Csaba Osztrogonác
Modified: 2009-07-27 03:39 PDT (History)
1 user (show)

See Also:

proposed patch (1.06 KB, patch)
2009-07-27 02:14 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff
proposed patch (1.24 KB, patch)
2009-07-27 03:36 PDT, Csaba Osztrogonác
hausmann: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2009-07-27 02:11:09 PDT
If building QtWebKit with MinGW-4.4, assembler stop the building,
because the inline assembly code below compiled to "call %*dl".
The "g" constraint should be "m", because *endPaint is nothing
but memory operand, such as *beginPaint in hookedBeginPaint 

WebCore/plugins/win/PluginViewWin.cpp - hookedEndPaint function:

asm ("push   %2\n"
     "push   %3\n"
     "call   *%4\n"
     : "=a" (result)
     : "a" (endPaintSysCall), "g" (lpPaint), "g" (hWnd), "g" (*endPaint)
Comment 1 Csaba Osztrogonác 2009-07-27 02:14:39 PDT
Created attachment 33526 [details]
proposed patch
Comment 2 Csaba Osztrogonác 2009-07-27 03:36:38 PDT
Created attachment 33530 [details]
proposed patch
Comment 3 Simon Hausmann 2009-07-27 03:38:45 PDT
Comment on attachment 33530 [details]
proposed patch

r=me. Thanks!
Comment 4 Simon Hausmann 2009-07-27 03:39:49 PDT
Landed in r46411