WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
276992
[JSC] Remove dead code for `String#replace` and `String#replaceAll`
https://bugs.webkit.org/show_bug.cgi?id=276992
Summary
[JSC] Remove dead code for `String#replace` and `String#replaceAll`
Sosuke Suzuki
Reported
2024-07-24 04:29:30 PDT
We've added a fast path for `String#replace(string, string)` at
https://commits.webkit.org/280990@main
. With this addition, whenever the `replaceValue` in `stringReplaceUsingStringSearch` is a string, the fast path is executed. Therefore, the slow path is only reached when `replaceValue` is a function.
Attachments
Add attachment
proposed patch, testcase, etc.
Sosuke Suzuki
Comment 1
2024-07-24 04:30:25 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/31148
EWS
Comment 2
2024-07-29 00:27:41 PDT
Committed
281485@main
(ed9c21817325): <
https://commits.webkit.org/281485@main
> Reviewed commits have been landed. Closing PR #31148 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2024-07-29 00:28:14 PDT
<
rdar://problem/132704428
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug