Bug 27699 – Would be nice if build-webkit on Mac respected WEBKITOUTPUTDIR and set SYMROOT/OBJROOT accordingly

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Tor Arne Vestbø]

As far as I can tell the only way to build WebKit on Mac in another directory than WebKitBuild is to set com.apple.Xcode PBXApplicationwideBuildSettings or com.apple.Xcode PBXProductDirectory, which would affect all XCode builds, not just WebKit (?). Since all other ports support WEBKITOUTPUTDIR, I figured I'd add support for it on Mac too. 

The patch restructures the determineBaseProductDir() function a bit so that the git branch is appended (if enabled) regardless of the port, and that baseProductDirOptions (SYMROOT/OBJROOT) is set for Mac even when the the baseProductDir is set by the user (this helps me shadow-build WebKit on mac).

[Tor Arne Vestbø]

Created attachment 33523 [details]
2009-07-27  Tor Arne Vestbø  <[e-mail]>

Reviewed by NOBODY (OOPS!).

build-webkit: Reorder logic for determining the baseProductDir

https://bugs.webkit.org/show_bug.cgi?id=27699

We now do port-spesific probing for the product dir first, and then
fall back to either the generic WEBKITOUTPUTDIR (which now also works
on Mac), or WebKitBuild.

Then we add the git branch if the git branch build option is enabled.

Finally we massage the product dir based on the port. For example the
Mac port will now always set the SYMROOT and OBJROOT configuration for
XCode.

* Scripts/webkitdirs.pm:
---
 2 files changed, 40 insertions(+), 25 deletions(-)

[Eric Seidel (no email)]

Comment on attachment 33523 [details]
2009-07-27  Tor Arne Vestbø  <[e-mail]>

Looks sane.

[Tor Arne Vestbø]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebKitTools/ChangeLog
	M	WebKitTools/Scripts/webkitdirs.pm
Committed r46532
	M	WebKitTools/ChangeLog
	M	WebKitTools/Scripts/webkitdirs.pm
r46532 = 5cb46a5750423a609fa347a4b0ba1ae2b3c0912f (svn/trunk)
No changes between current HEAD and refs/remotes/svn/trunk
Resetting to the latest refs/remotes/svn/trunk
http://trac.webkit.org/changeset/46532