RESOLVED FIXED 27697
WorkerThread needs to be refactored to separate out dedicated-worker functionality 
https://bugs.webkit.org/show_bug.cgi?id=27697
Summary WorkerThread needs to be refactored to separate out dedicated-worker function...
Andrew Wilson
Reported 2009-07-27 00:15:42 PDT
The current WorkerThread implementation contains some functionality that is only used for dedicated workers. We need to factor out this extra functionality into a separate DerivedWorkerThread derived class so we can create SharedWorkerThread using a common base class.
Attachments
proposed patch (30.90 KB, patch)
2009-07-27 00:41 PDT, Andrew Wilson 		levin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andrew Wilson
Comment 1 2009-07-27 00:41:04 PDT
Created attachment 33522 [details] proposed patch
David Levin
Comment 2 2009-07-28 02:21:17 PDT
Comment on attachment 33522 [details] proposed patch > diff --git a/WebCore/workers/WorkerThread.h b/WebCore/workers/WorkerThread.h > + WorkerContext* workerContext() { return m_workerContext.get(); } Can this ever return 0? If not, consider making it return WorkerContext&.
Andrew Wilson
Comment 3 2009-07-28 13:17:34 PDT
The worker thread can outlive the worker context (and it certainly predates the worker context - see WorkerThread::stop()) so I think returning a (possibly null) pointer from workerThread() is appropriate.
Peter Kasting
Comment 4 2009-07-28 17:28:38 PDT
Fixed in r46507.
David Levin
Comment 5 2009-07-28 17:35:10 PDT
Committed as http://trac.webkit.org/changeset/46507 With gtk (only) build fix committed as http://trac.webkit.org/changeset/46509
Note You need to log in before you can comment on or make changes to this bug.