Bug 27696 – Inspector: Console should show completions for the command line APIs

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Keishi Hattori]

Currently the completion candidates do not include command line APIs.

[Keishi Hattori]

Created attachment 33520 [details]
Patch

[Keishi Hattori]

Created attachment 33525 [details]
oops tabs

[Joseph Pecoraro]

Sort function for Object.sortedProperties is used in ObjectPropertiesSections.  You should that parameter (sortFunc) back.  If sortFunc is not provided then the normal sort() is applied so it works out fine.

Also what about global functions/classes?  For example:
String, Date, toString, Number, ...

[Keishi Hattori]

Created attachment 33549 [details]
Fixed sortedProperties

(In reply to comment #3)
> Sort function for Object.sortedProperties is used in ObjectPropertiesSections. 
> You should that parameter (sortFunc) back.  If sortFunc is not provided then
> the normal sort() is applied so it works out fine.

Sorry my mistake.

> Also what about global functions/classes?  For example:
> String, Date, toString, Number, ...

Great idea. My understanding is that those are specified are {DontEnum} so you need to keep a list of them. I think I'll file separate bug.

[Timothy Hatcher]

Comment on attachment 33549 [details]
Fixed sortedProperties


> +            commandLineAPI = commandLineAPI.reduce(function(a, prop) {
> +                if (prop.charAt(0) !== "_")
> +                    a.push(prop);
> +                return a;
> +            }, []);

This is pretty fancy. I never really used/liked reduce or map. I think this would be easier to read as a simple for loop that only appends things to properties not starting with "_".

I bet it will be less code too!

[Keishi Hattori]

Created attachment 33690 [details]
Eliminated reduce

[Keishi Hattori]

Created attachment 33693 [details]
Eliminated reduce

[David Levin]

Assign to levin for landing.

[David Levin]

Committed as http://trac.webkit.org/changeset/46526