Bug 27695 - There are many DOM Storage corner cases the layout tests don't currently cover.
Summary: There are many DOM Storage corner cases the layout tests don't currently cover.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Jeremy Orlow
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-26 21:14 PDT by Jeremy Orlow
Modified: 2009-07-28 13:29 PDT (History)
0 users

See Also:

Attachments
v1 (18.46 KB, patch)
2009-07-26 21:44 PDT, Jeremy Orlow 		abarth: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Orlow 2009-07-26 21:14:32 PDT 
There are many DOM Storage corner cases the layout tests don't currently cover.
Comment 1 Jeremy Orlow 2009-07-26 21:44:23 PDT 
Created attachment 33517 [details]
v1

Add some checks to existing layout tests.
Comment 2 Jeremy Orlow 2009-07-26 21:47:11 PDT 
Comment on attachment 33517 [details]
v1

Note that almost all of these will have to be done for sessionStorage as well.  It's my intention to do them once this is reviewed.  If it's cleaner, I can do those changes and add it to this patch.  Otherwise I can do them in another patch and just add it to this bug.
Comment 3 Adam Barth 2009-07-28 01:36:26 PDT 
Comment on attachment 33517 [details]
v1

Yay tests.  One comment:

+ log("window.sessionStorage == window.sessionStorage: " + (window.sessionStorage == window.sessionStorage));

You should test === too (in both places).
Comment 4 Jeremy Orlow 2009-07-28 13:29:41 PDT 
r46498