RESOLVED FIXED 27691
WebCore bindings: Implement ScriptArray bindings. 
https://bugs.webkit.org/show_bug.cgi?id=27691
Summary WebCore bindings: Implement ScriptArray bindings.
Pavel Feldman
Reported 2009-07-26 10:20:24 PDT
ScriptArray is needed for serialized DOM access from WebInspector.
Attachments
patch (20.97 KB, patch)
2009-07-26 11:15 PDT, Pavel Feldman 		timothy: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2009-07-26 11:15:36 PDT
Created attachment 33513 [details] patch
Pavel Feldman
Comment 2 2009-07-26 11:52:07 PDT
Please do not land this. I'd like to land it myself so that it fit Chromium cycle nicely. Thanks.
Pavel Feldman
Comment 3 2009-07-27 02:07:47 PDT
M WebCore/WebCore.pro M WebCore/ChangeLog M WebCore/WebCore.vcproj/WebCore.vcproj M WebCore/GNUmakefile.am M WebCore/WebCore.gypi A WebCore/bindings/js/ScriptArray.h A WebCore/bindings/js/ScriptArray.cpp A WebCore/bindings/v8/ScriptArray.h A WebCore/bindings/v8/ScriptArray.cpp M WebCore/WebCore.xcodeproj/project.pbxproj r46410 = 0d0d5a3789c6238f7ebded1a26467e15dcb28fb5 (trunk)
Oliver Hunt
Comment 4 2009-07-27 12:59:21 PDT
Comment on attachment 33513 [details] patch Um, why are the JSC bindings use JSLock? Is ScriptArray meant to be called from a separate thread?
Pavel Feldman
Comment 5 2009-07-27 13:05:39 PDT
(In reply to comment #4) > (From update of attachment 33513 [details]) > Um, why are the JSC bindings use JSLock? Is ScriptArray meant to be called > from a separate thread? I copied them from the ScriptObject without much thinking. AFAIK we are not calling Script* from any other threads. Dmitry, do you know why locks are there?
Timothy Hatcher
Comment 6 2009-07-27 13:11:00 PDT
Alexey Proskuryakov says the JSLock(flase) is just there to prevent the threading assertions and is a no-op. This patch is correct.
Note You need to log in before you can comment on or make changes to this bug.