Bug 276892 - Improve congratulations text in build-webkit by having the complete command to run needed a launcher
Summary: Improve congratulations text in build-webkit by having the complete command t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-07-22 11:07 PDT by Sam Weinig
Modified: 2024-07-23 08:38 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2024-07-22 11:07:52 PDT
The current "congratulation" text output at the end of build-webkit leads can be a bit confusing, especially if set-webkit-configuration is set to a different configuration than the what you just built. 

For instance, if you get a new clone of WebKit, and are following https://webkit.org/building-webkit/ by calling "build-webkit --debug", once you finish the build you will see:

====================================================================
 WebKit is now built (10m:31s). 
 To run Safari with this newly-built code, use the
 "Tools/Scripts/run-safari" script.
====================================================================

but if you run "Tools/Scripts/run-safari" it will fail with a confusing error about not finding JavaScriptCore:

"Can't find built framework at ".../WebKit/WebKitBuild/Release/JavaScriptCore.framework/Versions/A/JavaScriptCore"."

By including the complete set of arguments for the command, in this case, "Tools/Scripts/run-safari --debug", the first time experience can be a bit smoother.
Comment 1 Sam Weinig 2024-07-22 11:09:47 PDT
Proposed new text:

====================================================================
 WebKit is now built (10m:31s). 
 To run Safari with this newly-built code, use
 the command "Tools/Scripts/run-safari --debug".
====================================================================

(we can use argumentsForConfiguration() from webkitdirs.pm so that it matches whatever is needed, including --ios-simulator flags and whatnot).
Comment 2 Sam Weinig 2024-07-22 11:21:56 PDT
Pull request: https://github.com/WebKit/WebKit/pull/31072
Comment 3 EWS 2024-07-23 08:37:26 PDT
Committed 281246@main (66e951b57bb4): <https://commits.webkit.org/281246@main>

Reviewed commits have been landed. Closing PR #31072 and removing active labels.
Comment 4 Radar WebKit Bug Importer 2024-07-23 08:38:16 PDT
<rdar://problem/132325660>