Bug 276892 – Improve congratulations text in build-webkit by having the complete command to run needed a launcher

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Sam Weinig]

The current "congratulation" text output at the end of build-webkit leads can be a bit confusing, especially if set-webkit-configuration is set to a different configuration than the what you just built. 

For instance, if you get a new clone of WebKit, and are following https://webkit.org/building-webkit/ by calling "build-webkit --debug", once you finish the build you will see:

====================================================================
 WebKit is now built (10m:31s). 
 To run Safari with this newly-built code, use the
 "Tools/Scripts/run-safari" script.
====================================================================

but if you run "Tools/Scripts/run-safari" it will fail with a confusing error about not finding JavaScriptCore:

"Can't find built framework at ".../WebKit/WebKitBuild/Release/JavaScriptCore.framework/Versions/A/JavaScriptCore"."

By including the complete set of arguments for the command, in this case, "Tools/Scripts/run-safari --debug", the first time experience can be a bit smoother.

[Sam Weinig]

Proposed new text:

====================================================================
 WebKit is now built (10m:31s). 
 To run Safari with this newly-built code, use
 the command "Tools/Scripts/run-safari --debug".
====================================================================

(we can use argumentsForConfiguration() from webkitdirs.pm so that it matches whatever is needed, including --ios-simulator flags and whatnot).

[Sam Weinig]

Pull request: https://github.com/WebKit/WebKit/pull/31072

[EWS]

Committed 281246@main (66e951b57bb4): <https://commits.webkit.org/281246@main>

Reviewed commits have been landed. Closing PR #31072 and removing active labels.

[Radar WebKit Bug Importer]

<rdar://problem/132325660>