Created attachment 33496 [details] Test HTML file with same source as link. Shows inability to paste. If divs are set to display: none in CSS, you are unable to paste text into <input type="text"> elements or <textarea> elements. See example at http://ryankinal.cogia.net/test.php (source attached).
Confirmed with r46038.
<rdar://problem/7093024>
http://crbug.com/86680
Created attachment 112955 [details] fixes the bug
Created attachment 112956 [details] Updated changelog
Any reviewers?
Comment on attachment 112956 [details] Updated changelog View in context: https://bugs.webkit.org/attachment.cgi?id=112956&action=review > Source/WebCore/editing/ReplaceSelectionCommand.cpp:170 > + restoreAndRemoveTestRenderingNodesToFragment(holder.get()); Could you explain why you've added the statements above? I don't understand. > Source/WebCore/editing/ReplaceSelectionCommand.cpp:187 > + restoreAndRemoveTestRenderingNodesToFragment(holder.get()); Ditto.
Comment on attachment 112956 [details] Updated changelog View in context: https://bugs.webkit.org/attachment.cgi?id=112956&action=review >> Source/WebCore/editing/ReplaceSelectionCommand.cpp:170 >> + restoreAndRemoveTestRenderingNodesToFragment(holder.get()); > > Could you explain why you've added the statements above? I don't understand. I had to move the statements in lines 182-187 here because otherwise it would interfere with the way handleBeforeTextInsertedEvent calculates the current length. The change log comment "In addition, remove the node before dispatching beforeTextInserted event to avoid event listeners, in particular TextFieldInputType::handleBeforeTextInsertedEvent, from seeing the test node." corresponds to this point. >> Source/WebCore/editing/ReplaceSelectionCommand.cpp:187 >> + restoreAndRemoveTestRenderingNodesToFragment(holder.get()); > > Ditto. This code had to added because 182-187 had to be moved above editableRoot->dispatchEvent(evt, ec).
Comment on attachment 112956 [details] Updated changelog Thanks for the explanation. Looks good to me.
Thanks for the review!
Committed r99076: <http://trac.webkit.org/changeset/99076>
This caused bug 71483.