RESOLVED FIXED 276763
http/wpt/mediastream/mediastreamtrackprocessor-videoframe-timestamp.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=276763
Summary http/wpt/mediastream/mediastreamtrackprocessor-videoframe-timestamp.html is f...
Jonathan Bedard
Reported 2024-07-17 21:57:26 PDT
As can be seen in the history, https://results.webkit.org/?suite=layout-tests&test=http%2Fwpt%2Fmediastream%2Fmediastreamtrackprocessor-videoframe-timestamp.html, http/wpt/mediastream/mediastreamtrackprocessor-videoframe-timestamp.html is very flakey. This flakiness makes this test actively harmful in EWS, since it can easily fail during one test run and then pass during the clean-build retry.
Attachments
Radar WebKit Bug Importer
Comment 1 2024-07-17 21:59:33 PDT
Jonathan Bedard
Comment 2 2024-07-17 22:01:20 PDT
EWS
Comment 3 2024-07-17 22:17:07 PDT
Test gardening commit 281077@main (f06fba7c7937): <https://commits.webkit.org/281077@main> Reviewed commits have been landed. Closing PR #30942 and removing active labels.
EWS
Comment 4 2024-07-17 22:26:10 PDT
Test gardening commit 280938.32@safari-7619-branch (c96a0b054eb9): <https://commits.webkit.org/280938.32@safari-7619-branch> Reviewed commits have been landed. Closing PR #1410 and removing active labels.
youenn fablet
Comment 5 2024-07-18 02:07:49 PDT
Right, the issue is that becoming an observer requires to hop to main thread. Either we need to callOnMainThreadAndWait in MediaStreamTrackProcessor::VideoFrameObserverWrapper::start, or we need to allow to call addVideoFrameObserver from any thread, or change the test. I am inclined to do the first option as a stop gap.
EWS
Comment 6 2024-07-19 00:35:31 PDT
Committed 281125@main (89195dc481e8): <https://commits.webkit.org/281125@main> Reviewed commits have been landed. Closing PR #30953 and removing active labels.
EWS
Comment 7 2024-07-19 14:16:37 PDT
Committed 280938.74@integration/ci/131979190_89195dc481_safari-7619-branch (39ec01e046ea): <https://commits.webkit.org/280938.74@integration/ci/131979190_89195dc481_safari-7619-branch> Reviewed commits have been landed. Closing PR #1439 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.