Bug 276754 - Avoid crashing if traverseUnchangedSubtree can't find the same backingSharingProvider
Summary: Avoid crashing if traverseUnchangedSubtree can't find the same backingSharing...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matt Woodrow
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-07-17 19:36 PDT by Matt Woodrow
Modified: 2024-07-19 10:44 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Woodrow 2024-07-17 19:36:21 PDT 
This currently is a nullptr crash if backingProviderCandidateForLayer returns nullptr.

We should be able to see if the candidate used from the last update is still available, and use that to avoid the crash (but still render incorrectly).
Comment 1 Radar WebKit Bug Importer 2024-07-17 19:36:45 PDT 
<rdar://problem/131972979>
Comment 2 Matt Woodrow 2024-07-17 19:39:09 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/30937
Comment 3 EWS 2024-07-18 15:55:17 PDT 
Committed 281112@main (20ba7372309c): <https://commits.webkit.org/281112@main>

Reviewed commits have been landed. Closing PR #30937 and removing active labels.
Comment 4 EWS 2024-07-19 10:44:13 PDT 
Committed 280938.68@integration/ci/131972979_20ba737230_safari-7619-branch (f0e117fe07b8): <https://commits.webkit.org/280938.68@integration/ci/131972979_20ba737230_safari-7619-branch>

Reviewed commits have been landed. Closing PR #1435 and removing active labels.