RESOLVED FIXED 276741
Enable JSC_validateOptions on GTK 
https://bugs.webkit.org/show_bug.cgi?id=276741
Summary Enable JSC_validateOptions on GTK
Justin Michaud
Reported 2024-07-17 15:03:57 PDT
Enable JSC_validateOptions on GTK
Attachments
Add attachment proposed patch, testcase, etc.
Justin Michaud
Comment 1 2024-07-17 15:06:59 PDT
Pull request: https://github.com/WebKit/WebKit/pull/30925
EWS
Comment 2 2024-07-18 15:26:37 PDT
Committed 281106@main (e812e22f41af): <https://commits.webkit.org/281106@main> Reviewed commits have been landed. Closing PR #30925 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2024-07-18 15:27:15 PDT
<rdar://problem/132043022>
Diego Pino
Comment 4 2024-07-19 01:49:29 PDT
GTK-Linux-64bit-Release-Packaging-Nightly-Ubuntu2004 is broken after this patch. https://build.webkit.org/#/builders/30/builds/9027 The build error is the following: ``` In file included from /home/buildbot/webkitgtk/nightly/GTK-Linux-64bit-Release-Packaging-Nightly-Ubuntu2004/build/WebKitBuild/GTK/Release/JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-f2e18ffc-32.cpp:1: /home/buildbot/webkitgtk/nightly/GTK-Linux-64bit-Release-Packaging-Nightly-Ubuntu2004/build/Source/JavaScriptCore/runtime/Options.cpp:987:27: error: use of undeclared identifier 'environ' char** envp = environ; ^ ``` In Linux, `environ` is an extern variable defined in `unistd.h`.
Diego Pino
Comment 5 2024-07-19 01:54:02 PDT
Re-opening for pull request https://github.com/webkit/webkit/pull/30994
EWS
Comment 6 2024-07-19 05:11:35 PDT
Committed 281133@main (8e4157809750): <https://commits.webkit.org/281133@main> Reviewed commits have been landed. Closing PR #30994 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.