Bug 276718 - Stop conditionally setting macOS UA string version to 10_15_7
Summary: Stop conditionally setting macOS UA string version to 10_15_7
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Sneddon [:gsnedders]
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-07-17 09:03 PDT by Sam Sneddon [:gsnedders]
Modified: 2024-07-29 17:43 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Sneddon [:gsnedders] 2024-07-17 09:03:41 PDT 
We currently:

    String osVersion = systemMarketingVersionForUserAgentString();
    if (!osVersion.startsWith("10"_s))
        osVersion = "10_15_7"_s;

This branch is always taken, as we dropped support for macOS 10.15 and earlier several years ago.

Similar to iOS, we can simply hard code this value in the UA string at this point.
Comment 1 Sam Sneddon [:gsnedders] 2024-07-17 09:08:15 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/30907
Comment 2 Radar WebKit Bug Importer 2024-07-24 09:04:59 PDT 
<rdar://problem/132409584>
Comment 3 EWS 2024-07-29 17:43:03 PDT 
Committed 281530@main (49a2b0400d3f): <https://commits.webkit.org/281530@main>

Reviewed commits have been landed. Closing PR #30907 and removing active labels.