Bug 27671 – Add functions to print the glyph page trees for debugging

• Status: RESOLVED
• Resolution: FIXED
• Component: Text

Patch forthcoming

Created attachment 33478 [details]
Add functions to print the glyph page trees for debugging

[Darin Adler]

Comment on attachment 33478 [details]
Add functions to print the glyph page trees for debugging

> +#ifndef NDEBUG
> +#include "PlatformString.h"
> +#endif

I'm conflicted about how useful it is to have the #include be #ifndef'd. Maybe it's better to not do that.

But also, declaring a function that returns a String requires only a forward declaration, not the definition, so the include isn't needed.

> +#ifndef NDEBUG
> +#include "PlatformString.h"
> +#endif
> +
>  namespace WebCore {
>  
>  class FontPlatformData {
> @@ -107,6 +111,10 @@ public:
>  #endif
>      };
>  
> +#ifndef NDEBUG
> +    String description() const { return String(); }
> +#endif

In this case, and others like it, "PlatformString.h" is needed, but only because the implementation is in the header. Can we put the implementation in a .cpp file instead?

r=me, but consider a version with less PlatformString.h

Landed in <http://trac.webkit.org/projects/webkit/changeset/46388>.