Bug 27669 – [chromium] Default UI controls for <video> has rendering problems

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Hin-Chung Lam]

There are several problems about the default UI controls of <video> in Chromium port:

1. If <video> is used inside MediaDocument to play an audio file, the controls is 1 pixel tall.
2. A tag like <audio src="something" controls></audio> would hide all the time digits.
3. When playing a movie/audio more than an hour long, the hour digit is missing.

[Hin-Chung Lam]

Created attachment 33479 [details]
patch

[Hin-Chung Lam]

Created attachment 33480 [details]
patch

[Hin-Chung Lam]

dglazkov: This is a css change that will only affect the chromium port. It will be great if you can review it. Thanks!

[David Levin]

Comment on attachment 33480 [details]
patch

> Index: WebCore/ChangeLog
> @@ -1,3 +1,23 @@
> +'

Please get rid of this.

> [phone]  Alpha Lam  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        [chromium] Default UI controls for <video> has rendering problems
> +        https://bugs.webkit.org/show_bug.cgi?id=27669
> +
> +        Fixes the bug that <video> in MediaDocument is 1 pixel tall if
> +        it is playing an audio file by changing the style to be 16px

It looks like you made it 32px.

> +
> +        There is no layout test provided because this only affects the
> +        chromium port.

Couldn't there still could be a layout test (with different results for each platform: OSX, Chromium, etc.).

[Hin-Chung Lam]

Created attachment 33563 [details]
patch

[Hin-Chung Lam]

Created attachment 33564 [details]
patch

[David Levin]

Comment on attachment 33564 [details]
patch

> Index: WebCore/ChangeLog
> +        There is no new tests provided because this is already covered
> +        by existing tests.

Minor nit: There are

[Hin-Chung Lam]

Created attachment 33587 [details]
patch

The last one was made obsolete because this change includes on more fix and should be done together.

[Hin-Chung Lam]

Created attachment 33588 [details]
patch

[Hin-Chung Lam]

Created attachment 33589 [details]
patch

[David Levin]

Committed as http://trac.webkit.org/changeset/46501

[Hin-Chung Lam]

Another problem is found that when <video> is used in a MediaDocuemnt, the media controls bar overlaps with the video by 16 pixels.