Bug 27665 - Failed assertion in WorkerContext::~WorkerContext()
Summary: Failed assertion in WorkerContext::~WorkerContext()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Andrew Wilson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-24 13:58 PDT by Andrew Wilson
Modified: 2009-07-24 14:32 PDT (History)
2 users (show)

See Also:

Attachments
Fix for flaky tests (2.03 KB, patch)
2009-07-24 14:21 PDT, Andrew Wilson 		levin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Wilson 2009-07-24 13:58:35 PDT 
There's a race condition when WorkerContext shuts down, because the WorkerThread object can get freed before the WorkerContext constructor finishes executing.

We need to update the code to make sure we don't access the m_thread after calling workerContextDestroyed() because the pointer may not be valid.
Comment 1 Andrew Wilson 2009-07-24 14:21:47 PDT 
Created attachment 33472 [details]
Fix for flaky tests

Worker tests are slightly flaky after my earlier patch - this addresses that problem.
Comment 2 Dmitry Titov 2009-07-24 14:32:32 PDT 
Landed: http://trac.webkit.org/changeset/46376