Bug 27657 - Add more wince port files
: Add more wince port files
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Platform
: 528+ (Nightly build)
: Other Other
: P2 Normal
Assigned To: Nobody
:
Depends on:
Blocks: 23154
  Show dependency treegraph
 
Reported: 2009-07-24 08:59 PDT by Yong Li
Modified: 2009-08-06 07:20 PDT (History)
3 users (show)

See Also:


Attachments
the patch (47.27 KB, patch)
2009-07-24 09:09 PDT, Yong Li
no flags Details | Formatted Diff | Diff
remove svg/graphics/wince (1.58 KB, patch)
2009-08-06 07:12 PDT, Yong Li
no flags Details | Formatted Diff | Diff
remove the unnecessary platform file in svg/graphics (2.10 KB, patch)
2009-08-06 07:16 PDT, Yong Li
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yong Li 2009-07-24 08:59:41 PDT
Add new files only
Comment 1 Yong Li 2009-07-24 09:09:39 PDT
Created attachment 33454 [details]
the patch

        * loader/icon/wince/IconDatabaseWince.cpp: Added.
        * rendering/RenderThemeWince.cpp: Added.
        * rendering/RenderThemeWince.h: Added.
        * storage/wince/DatabaseThreadWince.cpp: Added.
        * storage/wince/DatabaseThreadWince.h: Added.
        * storage/wince/LocalStorageThreadWince.cpp: Added.
        * storage/wince/LocalStorageThreadWince.h: Added.
        * svg/graphics/wince/SVGResourceFilterWince.cpp: Added.
Comment 2 George Staikos 2009-07-24 09:31:00 PDT
Comment on attachment 33454 [details]
the patch


Subject to the following minor corrections:

> +++ b/WebCore/loader/icon/wince/IconDatabaseWince.cpp
> @@ -0,0 +1,82 @@
> +/*
> + *  Copyright (C) 2007 Staikos Computing Services Inc.

  Copyright should be Torch Mobile Inc.  Is the year correct?

> +#ifndef RenderThemeWincece_h
> +#define RenderThemeWincece_h

  Might want to fix that

  
Rest looks okay to me.
Comment 3 Adam Treat 2009-07-24 14:13:38 PDT
Landed with r46374.
Comment 4 Dirk Schulze 2009-08-06 02:51:31 PDT
This patch crated the folder  svg/graphics/wince/ and the file   svg/graphics/wince/SVGResourceFilterWince.cpp.

All platform dependent code was deleted in svg some months ago. Can someone make a follow up and delete this code?
Comment 5 George Staikos 2009-08-06 06:55:51 PDT
Yes we should do that.
Comment 6 Yong Li 2009-08-06 07:12:37 PDT
Created attachment 34207 [details]
remove svg/graphics/wince

the file is no longer necessary.
Comment 7 Yong Li 2009-08-06 07:16:45 PDT
Created attachment 34208 [details]
remove the unnecessary platform file in svg/graphics
Comment 8 George Staikos 2009-08-06 07:19:48 PDT
Comment on attachment 34208 [details]
remove the unnecessary platform file in svg/graphics

already landed
Comment 9 George Staikos 2009-08-06 07:20:13 PDT
r46842