Bug 27657 - Add more wince port files
: Add more wince port files
Status: RESOLVED FIXED
: WebKit
Platform
: 528+ (Nightly build)
: Other Other
: P2 Normal
Assigned To:
:
:
:
: 23154
  Show dependency treegraph
 
Reported: 2009-07-24 08:59 PST by
Modified: 2009-08-06 07:20 PST (History)


Attachments
the patch (47.27 KB, patch)
2009-07-24 09:09 PST, Yong Li
no flags Review Patch | Details | Formatted Diff | Diff
remove svg/graphics/wince (1.58 KB, patch)
2009-08-06 07:12 PST, Yong Li
no flags Review Patch | Details | Formatted Diff | Diff
remove the unnecessary platform file in svg/graphics (2.10 KB, patch)
2009-08-06 07:16 PST, Yong Li
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2009-07-24 08:59:41 PST
Add new files only
------- Comment #1 From 2009-07-24 09:09:39 PST -------
Created an attachment (id=33454) [details]
the patch

        * loader/icon/wince/IconDatabaseWince.cpp: Added.
        * rendering/RenderThemeWince.cpp: Added.
        * rendering/RenderThemeWince.h: Added.
        * storage/wince/DatabaseThreadWince.cpp: Added.
        * storage/wince/DatabaseThreadWince.h: Added.
        * storage/wince/LocalStorageThreadWince.cpp: Added.
        * storage/wince/LocalStorageThreadWince.h: Added.
        * svg/graphics/wince/SVGResourceFilterWince.cpp: Added.
------- Comment #2 From 2009-07-24 09:31:00 PST -------
(From update of attachment 33454 [details])

Subject to the following minor corrections:

> +++ b/WebCore/loader/icon/wince/IconDatabaseWince.cpp
> @@ -0,0 +1,82 @@
> +/*
> + *  Copyright (C) 2007 Staikos Computing Services Inc.

  Copyright should be Torch Mobile Inc.  Is the year correct?

> +#ifndef RenderThemeWincece_h
> +#define RenderThemeWincece_h

  Might want to fix that


Rest looks okay to me.
------- Comment #3 From 2009-07-24 14:13:38 PST -------
Landed with r46374.
------- Comment #4 From 2009-08-06 02:51:31 PST -------
This patch crated the folder  svg/graphics/wince/ and the file   svg/graphics/wince/SVGResourceFilterWince.cpp.

All platform dependent code was deleted in svg some months ago. Can someone make a follow up and delete this code?
------- Comment #5 From 2009-08-06 06:55:51 PST -------
Yes we should do that.
------- Comment #6 From 2009-08-06 07:12:37 PST -------
Created an attachment (id=34207) [details]
remove svg/graphics/wince

the file is no longer necessary.
------- Comment #7 From 2009-08-06 07:16:45 PST -------
Created an attachment (id=34208) [details]
remove the unnecessary platform file in svg/graphics
------- Comment #8 From 2009-08-06 07:19:48 PST -------
(From update of attachment 34208 [details])
already landed
------- Comment #9 From 2009-08-06 07:20:13 PST -------
r46842