WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
276533
Web Inspector: Parse attributes added via editing the tag name
https://bugs.webkit.org/show_bug.cgi?id=276533
Summary
Web Inspector: Parse attributes added via editing the tag name
Vadim Makeev
Reported
2024-07-12 03:22:04 PDT
Created
attachment 471876
[details]
Editing tag and atting attributes ## Problem Adding an attribute in the DOM tree inside of the Inspect panel is unusually complicated. Given the developers’ experience in code editors, one would expect to double-click the tag name and start typing. Unfortunately, the attribute gets dismissed this way. It even gets repeated in the closing tag, which looks weird. ## Solution Currently, there are two editing modes available: 1. When you double-click the tag name, the tag name editing mode is opened. 2. When you press the Enter key, the adding attribute mode is opened. The inspector should differentiate between tag name editing and adding attribute mode based on whether the space is typed. Since tag names cannot contain spaces, it seems obvious. Chrome DevTools does this: once you type a space, it goes to the adding attributes mode. Ideally, pressing enter should open one and only editing mode to edit both the tag name and attributes. What is what is figured out via parsing for spaces. ## Extra information Attached screenshot: 1. Editing a tag name via double-click 2. Adding an attribute via the Enter key 3. Editing a tag name to add an attribute 4. Adding an attribute via the context menu
Attachments
Editing tag and atting attributes
(373.10 KB, image/png)
2024-07-12 03:22 PDT
,
Vadim Makeev
no flags
Details
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2024-07-12 04:48:30 PDT
<
rdar://problem/131607290
>
Razvan Caliman
Comment 2
2024-07-22 10:16:58 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/31069
EWS
Comment 3
2024-07-29 09:50:08 PDT
Committed
281507@main
(0b084355708b): <
https://commits.webkit.org/281507@main
> Reviewed commits have been landed. Closing PR #31069 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug