WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
276488
[GTK] Remove GTK 3 comment from GTK 4 web view background color docs
https://bugs.webkit.org/show_bug.cgi?id=276488
Summary
[GTK] Remove GTK 3 comment from GTK 4 web view background color docs
Michael Catanzaro
Reported
2024-07-11 08:28:38 PDT
Alice says this comment only applies to GTK 3 and not GTK 4:
> Note that the parent window must have a RGBA visual and GtkWidget:app-paintable property set to TRUE for backgrounds colors to work.
Unfortunately, maintaining two different versions of the comment is annoying. It's also annoying to write "Do this if using GTK 3" in the GTK 4 version of the documentation. I'm inclined to optimize for GTK 4 and just delete the comment.
Attachments
Add attachment
proposed patch, testcase, etc.
Michael Catanzaro
Comment 1
2024-07-11 08:30:01 PDT
Well, actually we already have separate GTK 3 and GTK 4 source files here, so it's not so hard to have two different copies.
Michael Catanzaro
Comment 2
2024-07-11 08:53:26 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/30700
EWS
Comment 3
2024-07-12 00:05:49 PDT
Committed
280892@main
(2d8800de7fc8): <
https://commits.webkit.org/280892@main
> Reviewed commits have been landed. Closing PR #30700 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug