Bug 276443 - [JSC] Extend AssemblerBuffer's ARM64E hash to work on x86 as well
Summary: [JSC] Extend AssemblerBuffer's ARM64E hash to work on x86 as well
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-07-10 12:59 PDT by Marcus Plutowski
Modified: 2024-07-16 16:15 PDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marcus Plutowski 2024-07-10 12:59:16 PDT 
rdar://131483380
Obviously the underlying PAC instructions will not be present, and since x86 does not provide an equivalent facility whatever we implement will not provide significant security value. However, even a naive xor-checksum would still catch memory corruption in the AssemblerBuffer, and the resulting crash would be much more tractable than a crash inside of vmEntryToJavaScript.
Comment 1 Marcus Plutowski 2024-07-11 11:52:17 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/30709
Comment 2 Marcus Plutowski 2024-07-15 19:08:12 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/30843
Comment 3 Marcus Plutowski 2024-07-16 13:58:54 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/30879
Comment 4 Marcus Plutowski 2024-07-16 16:15:11 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/30843