WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
276431
[CSS] Tokenizer should distinguish newline from whitespace
https://bugs.webkit.org/show_bug.cgi?id=276431
Summary
[CSS] Tokenizer should distinguish newline from whitespace
Matthieu Dubet
Reported
2024-07-10 10:08:20 PDT
https://drafts.csswg.org/css-syntax/#tokenizer-definitions
newline U+000A LINE FEED. Note that U+000D CARRIAGE RETURN and U+000C FORM FEED are not included in this definition, as they are converted to U+000A LINE FEED during preprocessing. whitespace A newline, U+0009 CHARACTER TABULATION, or U+0020 SPACE. But currently we just consider newline as a whitespace character. CSSParserToken CSSTokenizer::whiteSpace(UChar /*cc*/) { auto startOffset = m_input.offset(); m_input.advanceUntilNonWhitespace(); // FIXME: This does not preserve whitespace type (like tabs). auto whitespaceCount = 1 + (m_input.offset() - startOffset); return CSSParserToken(whitespaceCount); } template<typename CharacterType> constexpr bool isASCIIWhitespace(CharacterType character) { return character == ' ' || character == '\n' || character == '\t' || character == '\r' || character == '\f'; }
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2024-07-10 10:35:56 PDT
<
rdar://problem/131474098
>
zak ridouh
Comment 2
2024-07-23 18:46:19 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/31139
EWS
Comment 3
2024-08-10 09:43:03 PDT
Committed
282084@main
(de28c5277420): <
https://commits.webkit.org/282084@main
> Reviewed commits have been landed. Closing PR #31139 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug