Bug 27643 - Update CodeGeneratorJS.pm to support passing JSDOMGlobalObject* to toJS calls
Summary: Update CodeGeneratorJS.pm to support passing JSDOMGlobalObject* to toJS calls
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 27634
  Show dependency tree / graph
 
Reported: 2009-07-24 01:22 PDT by Eric Seidel (no email)
Modified: 2009-07-24 02:15 PDT (History)
1 user (show)

See Also:

Attachments
patch (72.92 KB, patch)
2009-07-24 01:45 PDT, Eric Seidel (no email) 		abarth: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-07-24 01:22:58 PDT 
Update CodeGeneratorJS.pm to support passing JSDOMGlobalObject* to toJS calls

This is an attempt at making the patch for 27634 smaller.  It's still rather large, but hopefully more reviewable now.
Comment 1 Eric Seidel (no email) 2009-07-24 01:45:07 PDT 
Created attachment 33413 [details]
patch
Comment 2 Eric Seidel (no email) 2009-07-24 01:49:14 PDT 
Sadly I don't think I can make this patch much smaller w/o horribly complicating landing things.  Hopefully you'll find it straightforward to review.  The *only* intentionally changed files were JSDOMBinding.* and CodeGeneratorJS.pm.  The rest is the minimal amount of changes to support those to diffs.
Comment 3 Adam Barth 2009-07-24 02:08:44 PDT 
Comment on attachment 33413 [details]
patch

Yes.  You could have put the code generator clean up in a separate patch, but it's not needed now that I've reviewed it.
Comment 4 Eric Seidel (no email) 2009-07-24 02:15:54 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	M	LayoutTests/fast/dom/constructed-objects-prototypes-expected.txt
	M	LayoutTests/fast/dom/prototype-inheritance-2-expected.txt
	M	LayoutTests/fast/dom/prototype-inheritance-expected.txt
	M	WebCore/ChangeLog
	M	WebCore/bindings/js/JSCDATASectionCustom.cpp
	M	WebCore/bindings/js/JSCSSRuleCustom.cpp
	M	WebCore/bindings/js/JSCSSValueCustom.cpp
	M	WebCore/bindings/js/JSDOMBinding.cpp
	M	WebCore/bindings/js/JSDOMBinding.h
	M	WebCore/bindings/js/JSDOMWindowBase.cpp
	M	WebCore/bindings/js/JSDOMWindowBase.h
	M	WebCore/bindings/js/JSDocumentCustom.cpp
	M	WebCore/bindings/js/JSElementCustom.cpp
	M	WebCore/bindings/js/JSEventCustom.cpp
	M	WebCore/bindings/js/JSEventTarget.cpp
	M	WebCore/bindings/js/JSEventTarget.h
	M	WebCore/bindings/js/JSHTMLCollectionCustom.cpp
	M	WebCore/bindings/js/JSImageDataCustom.cpp
	M	WebCore/bindings/js/JSNodeCustom.cpp
	M	WebCore/bindings/js/JSSVGElementInstanceCustom.cpp
	M	WebCore/bindings/js/JSSVGMatrixCustom.cpp
	M	WebCore/bindings/js/JSSVGPathSegCustom.cpp
	M	WebCore/bindings/js/JSSVGPathSegListCustom.cpp
	M	WebCore/bindings/js/JSSVGPointListCustom.cpp
	M	WebCore/bindings/js/JSSVGTransformListCustom.cpp
	M	WebCore/bindings/js/JSStyleSheetCustom.cpp
	M	WebCore/bindings/js/JSTextCustom.cpp
	M	WebCore/bindings/js/JSWorkerContextBase.cpp
	M	WebCore/bindings/js/JSWorkerContextBase.h
	M	WebCore/bindings/scripts/CodeGeneratorJS.pm
Committed r46346
	M	WebCore/ChangeLog
	M	WebCore/bindings/scripts/CodeGeneratorJS.pm
	M	WebCore/bindings/js/JSTextCustom.cpp
	M	WebCore/bindings/js/JSCSSValueCustom.cpp
	M	WebCore/bindings/js/JSHTMLCollectionCustom.cpp
	M	WebCore/bindings/js/JSCSSRuleCustom.cpp
	M	WebCore/bindings/js/JSElementCustom.cpp
	M	WebCore/bindings/js/JSSVGPathSegCustom.cpp
	M	WebCore/bindings/js/JSWorkerContextBase.cpp
	M	WebCore/bindings/js/JSEventCustom.cpp
	M	WebCore/bindings/js/JSEventTarget.h
	M	WebCore/bindings/js/JSDOMWindowBase.h
	M	WebCore/bindings/js/JSImageDataCustom.cpp
	M	WebCore/bindings/js/JSWorkerContextBase.h
	M	WebCore/bindings/js/JSSVGMatrixCustom.cpp
	M	WebCore/bindings/js/JSStyleSheetCustom.cpp
	M	WebCore/bindings/js/JSSVGElementInstanceCustom.cpp
	M	WebCore/bindings/js/JSDOMWindowBase.cpp
	M	WebCore/bindings/js/JSSVGPathSegListCustom.cpp
	M	WebCore/bindings/js/JSDOMBinding.h
	M	WebCore/bindings/js/JSDOMBinding.cpp
	M	WebCore/bindings/js/JSCDATASectionCustom.cpp
	M	WebCore/bindings/js/JSSVGPointListCustom.cpp
	M	WebCore/bindings/js/JSSVGTransformListCustom.cpp
	M	WebCore/bindings/js/JSDocumentCustom.cpp
	M	WebCore/bindings/js/JSNodeCustom.cpp
	M	WebCore/bindings/js/JSEventTarget.cpp
	M	LayoutTests/ChangeLog
	M	LayoutTests/fast/dom/constructed-objects-prototypes-expected.txt
	M	LayoutTests/fast/dom/prototype-inheritance-2-expected.txt
	M	LayoutTests/fast/dom/prototype-inheritance-expected.txt
r46346 = 2495069585adfd98432c6f1344514c465d1dfcf3 (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
http://trac.webkit.org/changeset/46346