Bug 27641 - Classes call DOMObject::mark() explicitly, should call DOMObjectWithGlobal::mark() instead
Summary: Classes call DOMObject::mark() explicitly, should call DOMObjectWithGlobal::m...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 27634
  Show dependency treegraph
 
Reported: 2009-07-24 00:03 PDT by Eric Seidel (no email)
Modified: 2009-07-24 00:14 PDT (History)
0 users

See Also:


Attachments
patch (6.78 KB, patch)
2009-07-24 00:08 PDT, Eric Seidel (no email)
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-07-24 00:03:48 PDT
Classes call DOMObject::mark() explicitly, should call DOMObjectWithGlobal::mark() instead

Actually I'm going to change these to Base::mark() instead for future-proofing.  All the auto-gen bindings define a Base typedef which is the superclass.  So sad that c++ doesn't just have a super:: call built-in. :(
Comment 1 Eric Seidel (no email) 2009-07-24 00:08:27 PDT
Created attachment 33410 [details]
patch
Comment 2 Adam Barth 2009-07-24 00:10:06 PDT
Comment on attachment 33410 [details]
patch

Yep.  C++ is the suck.
Comment 3 Eric Seidel (no email) 2009-07-24 00:14:40 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/bindings/js/JSAbstractWorkerCustom.cpp
	M	WebCore/bindings/js/JSDOMApplicationCacheCustom.cpp
	M	WebCore/bindings/js/JSMessageChannelCustom.cpp
	M	WebCore/bindings/js/JSMessagePortCustom.cpp
	M	WebCore/bindings/js/JSNamedNodesCollection.cpp
	M	WebCore/bindings/js/JSNodeCustom.cpp
	M	WebCore/bindings/js/JSNodeFilterCustom.cpp
	M	WebCore/bindings/js/JSNodeIteratorCustom.cpp
	M	WebCore/bindings/js/JSSVGElementInstanceCustom.cpp
	M	WebCore/bindings/js/JSTreeWalkerCustom.cpp
Committed r46322
	M	WebCore/ChangeLog
	M	WebCore/bindings/js/JSDOMApplicationCacheCustom.cpp
	M	WebCore/bindings/js/JSNodeFilterCustom.cpp
	M	WebCore/bindings/js/JSAbstractWorkerCustom.cpp
	M	WebCore/bindings/js/JSNamedNodesCollection.cpp
	M	WebCore/bindings/js/JSSVGElementInstanceCustom.cpp
	M	WebCore/bindings/js/JSMessageChannelCustom.cpp
	M	WebCore/bindings/js/JSMessagePortCustom.cpp
	M	WebCore/bindings/js/JSNodeCustom.cpp
	M	WebCore/bindings/js/JSNodeIteratorCustom.cpp
	M	WebCore/bindings/js/JSTreeWalkerCustom.cpp
r46322 = 9074277481c1c10c1941550c44bda829678c5499 (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
http://trac.webkit.org/changeset/46322