Bug 27636 - [Gtk] Add implementation of GCController for DRT
Summary: [Gtk] Add implementation of GCController for DRT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2009-07-23 21:44 PDT by Jan Alonzo
Modified: 2009-07-23 23:52 PDT (History)
0 users

See Also:

Attachments
patch (6.94 KB, patch)
2009-07-23 21:47 PDT, Jan Alonzo 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Alonzo 2009-07-23 21:44:05 PDT 
Gtk DRT's GCController is currently missing an implementation. Patch coming to add an impl and enable a couple more test.
Comment 1 Jan Alonzo 2009-07-23 21:47:58 PDT 
Created attachment 33405 [details]
patch
Comment 2 Eric Seidel (no email) 2009-07-23 23:07:25 PDT 
Comment on attachment 33405 [details]
patch

Looks fine.

I'm surprised you all don't have a macro for DELETE_AND_ZERO:
delete gcController;
 689     gcController = 0;

The Mac DRT has one for RELEASE_AND_ZERO iirc.
Comment 3 Jan Alonzo 2009-07-23 23:52:36 PDT 
(In reply to comment #2)
> (From update of attachment 33405 [details])
> Looks fine.
> 
> I'm surprised you all don't have a macro for DELETE_AND_ZERO:
> delete gcController;
>  689     gcController = 0;
> 
> The Mac DRT has one for RELEASE_AND_ZERO iirc.

Hi Eric. Thanks for the r+. Landed as http://trac.webkit.org/changeset/46319.

WRT releaseAndZero, it wasn't really needed before as we only had gLayoutTestController to zero. releaseAndZero will probably be handy once we enable more functionality to our DRT.

Thanks for bringing it up.