RESOLVED FIXED 27635
Make get_by_id/put_by_id/method_check/call defer optimization using a data flag rather than a code modification. 
https://bugs.webkit.org/show_bug.cgi?id=27635
Summary Make get_by_id/put_by_id/method_check/call defer optimization using a data fl...
Gavin Barraclough
Reported 2009-07-23 21:22:23 PDT
This will improve the performance of ENABLE(ASSEMBLER_WX_EXCLUSIVE) builds.
Attachments
The Patch. (46.37 KB, patch)
2009-07-23 22:05 PDT, Gavin Barraclough 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2009-07-23 22:05:22 PDT
Created attachment 33406 [details] The Patch.
Geoffrey Garen
Comment 2 2009-07-23 22:32:59 PDT
It looks like this patch might create conflicts with the merge I'm working on. The PtrAndFlags, StructureStubInfo and CodeBlock changes probably won't conflict, and removing virtualCallPreLinkBegin probably won't conflict too much (modulo a file move), but I'm worried that the JITCall and JITStubs changes risk making diff very confused, since I've made a lot of changes in the same areas. Do you think you can hold off landing until after Friday? I gave the patch a brief review, and it looks good to me.
Gavin Barraclough
Comment 3 2009-07-30 19:21:06 PDT
Sending JavaScriptCore/ChangeLog Sending JavaScriptCore/bytecode/CodeBlock.cpp Sending JavaScriptCore/bytecode/CodeBlock.h Sending JavaScriptCore/bytecode/StructureStubInfo.cpp Sending JavaScriptCore/bytecode/StructureStubInfo.h Sending JavaScriptCore/bytecompiler/BytecodeGenerator.cpp Sending JavaScriptCore/jit/JIT.cpp Sending JavaScriptCore/jit/JIT.h Sending JavaScriptCore/jit/JITCall.cpp Sending JavaScriptCore/jit/JITOpcodes.cpp Sending JavaScriptCore/jit/JITStubs.cpp Sending JavaScriptCore/jit/JITStubs.h Sending JavaScriptCore/wtf/PtrAndFlags.h Transmitting file data ............. Committed revision 46618.
Gavin Barraclough
Comment 4 2009-08-06 20:13:43 PDT
Sending JavaScriptCore/ChangeLog Sending JavaScriptCore/bytecode/CodeBlock.cpp Sending JavaScriptCore/bytecode/CodeBlock.h Sending JavaScriptCore/bytecode/StructureStubInfo.cpp Sending JavaScriptCore/bytecode/StructureStubInfo.h Sending JavaScriptCore/bytecompiler/BytecodeGenerator.cpp Sending JavaScriptCore/jit/JIT.cpp Sending JavaScriptCore/jit/JIT.h Sending JavaScriptCore/jit/JITCall.cpp Sending JavaScriptCore/jit/JITOpcodes.cpp Sending JavaScriptCore/jit/JITPropertyAccess.cpp Sending JavaScriptCore/jit/JITStubs.cpp Sending JavaScriptCore/jit/JITStubs.h Sending JavaScriptCore/wtf/PtrAndFlags.h Transmitting file data .............. Committed revision 46879. Trying again.....
Note You need to log in before you can comment on or make changes to this bug.