WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
276297
Remove `other` from SFrameTransformErrorEventType interface as per web specification
https://bugs.webkit.org/show_bug.cgi?id=276297
Summary
Remove `other` from SFrameTransformErrorEventType interface as per web specif...
Ahmad Saleem
Reported
2024-07-07 07:51:05 PDT
Hi Team, While looking into WebRTC spec, I noticed that we have additional `other` error event type. Web-Spec:
https://w3c.github.io/webrtc-encoded-transform/#enumdef-sframetransformerroreventtype
WebKit Source:
https://searchfox.org/wubkat/rev/c994460e362bfdfa5706e5fb55b79eef38f51527/Source/WebCore/Modules/mediastream/RTCRtpSFrameTransformErrorEvent.idl#29
___ We need to do following: In 'IDL' file:
https://searchfox.org/wubkat/rev/c994460e362bfdfa5706e5fb55b79eef38f51527/Source/WebCore/Modules/mediastream/RTCRtpSFrameTransformErrorEvent.idl#29
Remove `other` In '.h' file:
https://searchfox.org/wubkat/rev/c994460e362bfdfa5706e5fb55b79eef38f51527/Source/WebCore/Modules/mediastream/RTCRtpSFrameTransformErrorEvent.idl#29
Remove `other` from enum In `.cpp` file:
https://searchfox.org/wubkat/rev/c994460e362bfdfa5706e5fb55b79eef38f51527/Source/WebCore/Modules/mediastream/RTCRtpSFrameTransform.cpp#120
Remove: case RTCRtpSFrameTransformer::Error::Other: return RTCRtpSFrameTransformErrorEvent::Type::Other; ______ Just raising so we can track and fix it. Thanks!
Attachments
Add attachment
proposed patch, testcase, etc.
EWS
Comment 1
2024-07-11 16:09:39 PDT
Committed
280880@main
(2124f58f2dae): <
https://commits.webkit.org/280880@main
> Reviewed commits have been landed. Closing PR #30646 and removing active labels.
Radar WebKit Bug Importer
Comment 2
2024-07-11 16:10:16 PDT
<
rdar://problem/131572447
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug