WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
276294
Remove `overflow: auto` for `textarea` from `StyleAdjuster.cpp`
https://bugs.webkit.org/show_bug.cgi?id=276294
Summary
Remove `overflow: auto` for `textarea` from `StyleAdjuster.cpp`
Ahmad Saleem
Reported
2024-07-06 19:21:11 PDT
Hi Team, While exploring WPT failures on InterOp 2023, I noticed that we fail one test (also Chrome) for textarea:
http://wpt.live/html/rendering/non-replaced-elements/form-controls/resets.html
> <textarea> - overflow
and noticed that we have following in `StyleAdjuster.cpp`:
https://searchfox.org/wubkat/rev/426186a23c4afc5565407d381766d9cfb9620156/Source/WebCore/style/StyleAdjuster.cpp#570
Remove this: // Textarea considers overflow visible as auto. if (is<HTMLTextAreaElement>(*m_element)) { style.setOverflowX(style.overflowX() == Overflow::Visible ? Overflow::Auto : style.overflowX()); style.setOverflowY(style.overflowY() == Overflow::Visible ? Overflow::Auto : style.overflowY()); } and we progress above but I tried to find reference in HTML WHATWG but couldn't manage to find it. Thanks!
Attachments
test results in safari, firefox, chromering
(2.17 MB, image/png)
2024-07-08 00:08 PDT
,
Karl Dubost
no flags
Details
View All
Add attachment
proposed patch, testcase, etc.
Ahmad Saleem
Comment 1
2024-07-06 19:24:45 PDT
Strange - for some reason, it makes following pass as well. wrap-enumerated-ascii-case-insensitive.html
Karl Dubost
Comment 2
2024-07-08 00:08:51 PDT
Created
attachment 471838
[details]
test results in safari, firefox, chromering tested in Safari Technology Preview 198 20619.1.20.7 Firefox Nightly 129.0a1 12924.7.4 Google Chrome Canary 128.0.6582.0 6582.0 assert_equals: expected "visible" but got "auto" @
http://wpt.live/html/rendering/support/test-ua-stylesheet.js:34:21
@
http://wpt.live/resources/testharness.js:2622:30
test@
http://wpt.live/resources/testharness.js:633:34
runUAStyleTests@
http://wpt.live/html/rendering/support/test-ua-stylesheet.js:33:10
global code@
http://wpt.live/html/rendering/non-replaced-elements/form-controls/resets.html:117:17
Asserts run Fail assert_equals("auto", "visible") /html/rendering/support/test-ua-stylesheet.js:34:21
Ahmad Saleem
Comment 3
2024-07-08 13:05:39 PDT
It was added here:
https://github.com/WebKit/WebKit/commit/cbc0361bab42fce24473523af0a83c93ba612ce3
33849@main
in 2009.
Radar WebKit Bug Importer
Comment 4
2024-07-13 19:22:13 PDT
<
rdar://problem/131685655
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug