RESOLVED FIXED 27627
DRT animation/transition pause API does not pause accelerated animations 
https://bugs.webkit.org/show_bug.cgi?id=27627
Summary DRT animation/transition pause API does not pause accelerated animations
Simon Fraser (smfr)
Reported 2009-07-23 15:16:15 PDT
The 'pauseAnimationAtTimeOnElementWithId' and 'pauseTransitionAtTimeOnElementWithId' methods available to JS in DRT don't do the right thing for animations that are accelerated, making it hard to write tests that give pixel-accurate results for these kinds of animations.
Attachments
Patch, changelogs (46.34 KB, patch)
2009-07-23 15:22 PDT, Simon Fraser (smfr) 		mitz: review+
DetailsFormatted DiffDiff
Unbitrotted patch, some tests need tweaking still. (40.91 KB, patch)
2009-07-31 18:24 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2009-07-23 15:16:46 PDT
<rdar://problem/6442932>
Simon Fraser (smfr)
Comment 2 2009-07-23 15:22:20 PDT
Created attachment 33385 [details] Patch, changelogs
mitz
Comment 3 2009-07-24 11:33:45 PDT
Comment on attachment 33385 [details] Patch, changelogs Minor style issues: > -void AnimationBase::pauseAtTime(double t) > +void AnimationBase::freezeAtTime(double t) While you’re at it, please rename 't' to 'time'. > + ASSERT(m_startTime); // if m_startTime is zero, we haven't started yet, so we'll get a bad pause time. Since it ends with a period, it must begin with a capital “If” instead of “if”. > + void freezeAtTime(double t); No need to name the parameter here. > + virtual void suspendAnimations(double time = 0); // zero value for time means "use currentTime()". “Zero” instead of “zero”.
Simon Fraser (smfr)
Comment 4 2009-07-31 18:24:39 PDT
Created attachment 33916 [details] Unbitrotted patch, some tests need tweaking still.
Simon Fraser (smfr)
Comment 5 2009-08-03 12:40:27 PDT
http://trac.webkit.org/changeset/46727
Note You need to log in before you can comment on or make changes to this bug.