Bug 27626 – To allow disabling DataGrid, conditionalize its files in DerivedSourcesAllInOne

• Status: RESOLVED
• Resolution: INVALID
• Component: WebCore JavaScript

[Jens Alfke]

My previous patch (bug 27383) was designed to, among other things, allow setting ENABLE_DATAGRID to 0, which we want to do in Chromium until the functionality is more fleshed-out. However, there's one more change needed for that which I didn't catch: conditionalizing the #includes of the DataGrid cpp files in DerivedSourcesAllInOne.cpp.

For some reason this didn't cause errors on my machine (perhaps because of left-over already built files?) but my new Chromium patch for turning off ENABLE_DATAGRID is failing on our buildbots, so before I can submit that to Chromium I need to submit the remaining WebKit bit over here...

[Jens Alfke]

Created attachment 33381 [details]
patch to fix it

(Note that this patch only affects platforms that build V8 not JSC.)

[Darin Fisher (:fishd, Google)]

Comment on attachment 33381 [details]
patch to fix it

This looks good, but it needs ChangeLog entry.

[Jens Alfke]

Created attachment 33383 [details]
Now with changelog entry, duh

[Eric Seidel (no email)]

Comment on attachment 33383 [details]
Now with changelog entry, duh

Why aren't these inside the DataGrid files?

Normally we just use Condition=DATAGRID in the idl files and it magically adds all this for you.  Why not here?

[Jens Alfke]

Eric: This is V8, not JSC. Apparently our code generator isn't as magical yet as yours.

[Jens Alfke]

This turned out not to be the cause of the build problem; the patch isn't necessary. I'll close the bug.

[David Levin]

Comment on attachment 33383 [details]
Now with changelog entry, duh

Clearing r? per snej's comment in bug.