Bug 276212 - [macOS] fast/canvas/canvas-drawImage-hdr-video.html is constantly failing on Sequoia
Summary: [macOS] fast/canvas/canvas-drawImage-hdr-video.html is constantly failing on ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-07-03 17:05 PDT by Said Abou-Hallawa
Modified: 2024-07-03 23:35 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2024-07-03 17:05:18 PDT 
Drawing a frame from an HDR video to a canvas has been slightly incorrect. In macOS Sequoia the math for converting the HDR frame to SDR frame has been fixed. So this test is working correctly on Sequoia only. So the plan for this is the following:

1. The test will be skipped for all ports.
2. It's currently skipped on WinCairo and marked [ Failure ] on glib ports. So the entries in these TestExpectations will be removed.
3. It will be marked as [ Pass ] on macOS TestExpectations.
Comment 1 Said Abou-Hallawa 2024-07-03 17:05:46 PDT 
rdar://130628077
Comment 2 Said Abou-Hallawa 2024-07-03 17:06:36 PDT 
The behavior on macOS Sequoia is a progression for this test.
Comment 3 Said Abou-Hallawa 2024-07-03 17:12:34 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/30475
Comment 4 EWS 2024-07-03 23:35:21 PDT 
Committed 280659@main (dd2e59c74660): <https://commits.webkit.org/280659@main>

Reviewed commits have been landed. Closing PR #30475 and removing active labels.