Bug 276205 - REGRESSION (280591@main?): imported/w3c/web-platform-tests/navigation-api/navigate-event/replaceState-inside-back-handler.html is constantly failing.
Summary: REGRESSION (280591@main?): imported/w3c/web-platform-tests/navigation-api/nav...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Charlie Wolfe
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-07-03 15:18 PDT by Anfernee Viduya
Modified: 2024-07-05 13:33 PDT (History)
6 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Anfernee Viduya 2024-07-03 15:18:02 PDT
imported/w3c/web-platform-tests/navigation-api/navigate-event/replaceState-inside-back-handler.html 
is constantly failing on macOS and iOS.

HISTORY: 
https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fnavigation-api%2Fnavigate-event%2FreplaceState-inside-back-handler.html&platform=mac&platform=ios
 
DIFF:
-CONSOLE MESSAGE: RangeError: Maximum call stack size exceeded.
+CONSOLE MESSAGE: SecurityError: Attempt to use history.replaceState() more than 100 times per 10 seconds
 
-Harness Error (FAIL), message = RangeError: Maximum call stack size exceeded.
+Harness Error (FAIL), message = SecurityError: Attempt to use history.replaceState() more than 100 times per 10 seconds
 
 PASS replaceState inside a navigate event for navigation.back()
 

LINK: 
https://build.webkit.org/results/Apple-Sonoma-Release-AppleSilicon-WK2-Tests/280592@main%20(4525)/imported/w3c/web-platform-tests/navigation-api/navigate-event/replaceState-inside-back-handler-diff.txt

REGRESSION: 
In the 280591@main, changes were made in WebCore/History navigation which might've caused the regression.
Comment 1 Radar WebKit Bug Importer 2024-07-03 15:18:13 PDT
<rdar://problem/131080588>
Comment 2 Anfernee Viduya 2024-07-03 16:30:31 PDT
REPRODUCIBILITY: 
I was able to reproduce this regression on ToT using the command, 
run-webkit-tests --root imported/w3c/web-platform-tests/navigation-api/navigate-event/replaceState-inside-back-handler.html
Comment 3 Anfernee Viduya 2024-07-03 16:42:20 PDT
It looks like 280591@main regressed this but I am uncertain because that particular commit was not built.
Comment 4 Charlie Wolfe 2024-07-03 18:05:45 PDT
Pull request: https://github.com/WebKit/WebKit/pull/30479
Comment 5 EWS 2024-07-05 13:33:42 PDT
Committed 280699@main (6e0990321f04): <https://commits.webkit.org/280699@main>

Reviewed commits have been landed. Closing PR #30479 and removing active labels.