Bug 276180 – WebKitDOMEventTarget.h:95: Warning: WebKit2WebExtension: invalid "scope" annotation: only valid on callback parameters

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Michael Catanzaro]

Since https://gitlab.gnome.org/GNOME/gobject-introspection/-/merge_requests/477 it's no longer possible to build for GTK 3 because we have fatal introspection warnings enabled:

Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMEventTarget.h:95: Warning: WebKit2WebExtension: invalid "scope" annotation: only valid on callback parameters

Emmanuele recommends using (type gpointer) for the GCallback parameter of webkit_dom_event_target_remove_event_listener(), since it won't be called and is therefore not functioning as a callback.

Also:

"""
the `(scope async)` on add_event_listener() is also broken, because it's not an async function; but since the function is missing a GDestroyNotify to begin with, there's no way to properly annotate it
`(scope forever)` is the closest option, but that'll leak anything that tries to use it
"""

But I'll leave this broken because it's not clear whether it's fixable and this API is deprecated.

[Michael Catanzaro]

Pull request: https://github.com/WebKit/WebKit/pull/30446

[EWS]

Committed 280639@main (fff1b1773bff): <https://commits.webkit.org/280639@main>

Reviewed commits have been landed. Closing PR #30446 and removing active labels.