Bug 27618 – WebCore/page/DOMTimer.cpp/h does not conform to style standards

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Mike Fenton]

cpplint reports a number of valid style fixes that should be made to
WebCore/page/DOMTimer.cpp/h.

[Mike Fenton]

Created attachment 33356 [details]
Style patch for DOMTimer.cpp/h

[Darin Adler]

Comment on attachment 33356 [details]
Style patch for DOMTimer.cpp/h

It seems that most of this patch is about stripping trailing whitespace. I didn't know we had a convention that said this was important.

[Adam Treat]

In the absence of (In reply to comment #2)
> (From update of attachment 33356 [details])
> It seems that most of this patch is about stripping trailing whitespace. I
> didn't know we had a convention that said this was important.

In the abscense of other styling errors, maybe not.  But in addition to...  Why not?  They serve no useful purpose and can be distracting in some editors that highlight them.

[Mike Fenton]

This patch does include non-whitespace changes as well as whitespace changes.

[Eric Seidel (no email)]

Comment on attachment 33356 [details]
Style patch for DOMTimer.cpp/h

I wish XCode would strip whitespace for me. ;)

The changes look fine.

[Adam Barth]

Will land.

[Adam Barth]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/page/DOMTimer.cpp
	M	WebCore/page/DOMTimer.h
Committed r46324
	M	WebCore/ChangeLog
	M	WebCore/page/DOMTimer.h
	M	WebCore/page/DOMTimer.cpp
r46324 = 33c74813d8d1eb35a78b02d4d954b5890c1b7285 (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
http://trac.webkit.org/changeset/46324