Bug 276145 – NEW TEST (279835@main): [ macOS Debug wk1 ] http/tests/security/block-popup-to-all-zero-address.html is a constant crash

• Status: REOPENED
• Component: New Bugs

[Anfernee Viduya]

DESCRIPTION: 
http/tests/security/block-popup-to-all-zero-address.html 
is constantly crashing on macOS Ventura and Sonoma in wk1 since the test was introduced on 279835@main 

HISTORY: 
https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Fsecurity%2Fblock-popup-to-all-zero-address.html&limit=50000&recent=false&recent=false&platform=mac&flavor=wk1 

REPRODUCIBILITY:
I was able to reproduce the issue at ToT using this command using wk1 flag. 
run-webkit-test --root http/tests/security/block-popup-to-all-zero-address.html -1

Crash Log: 
ASSERTION FAILED: gTestRunner->waitToDump() || WTR::hasTestWaitAttribute(mainFrame.globalContext)
/Volumes/Data/worker/Apple-Sonoma-Debug-Build/build/Tools/DumpRenderTree/mac/UIDelegate.mm(179) : -[UIDelegate webView:createWebViewWithRequest:]
1   0x104f0198c -[UIDelegate webView:createWebViewWithRequest:]
2   0x10d85c914 objc_object* wtfObjCMsgSend<objc_object*, WebView*, objc_object*>(objc_object*, objc_selector*, WebView*, objc_object*)
3   0x10d859afc CallDelegate(WebView*, objc_object*, objc_selector*, objc_object*)
4   0x10d859a90 CallUIDelegate(WebView*, objc_selector*, objc_object*)
5   0x10d8418f8 WebChromeClient::createWindow(WebCore::LocalFrame&, WebCore::WindowFeatures const&, WebCore::NavigationAction const&)
6   0x12ab8188c WebCore::Chrome::createWindow(WebCore::LocalFrame&, WebCore::WindowFeatures const&, WebCore::NavigationAction const&)
7   0x12a9a9de8 WebCore::createWindow(WebCore::LocalFrame&, WebCore::LocalFrame&, WebCore::FrameLoadRequest&&, WebCore::WindowFeatures&, bool&)
8   0x12ac72100 WebCore::LocalDOMWindow::createWindow(WTF::String const&, WTF::AtomString const&, WebCore::WindowFeatures const&, WebCore::LocalDOMWindow&, WebCore::LocalFrame&, WebCore::LocalFrame&, WTF::Function<void (WebCore::LocalDOMWindow&)> const&)
9   0x12ac731f0 WebCore::LocalDOMWindow::open(WebCore::LocalDOMWindow&, WebCore::LocalDOMWindow&, WTF::String const&, WTF::AtomString const&, WTF::String const&)
10  0x12ab9f2a4 WebCore::DOMWindow::open(WebCore::LocalDOMWindow&, WebCore::LocalDOMWindow&, WTF::String const&, WTF::AtomString const&, WTF::String const&)

Link to crash log:
https://build.webkit.org/results/Apple-Sonoma-Debug-AppleSilicon-WK1-Tests/280582@main%20(3462)/http/tests/security/block-popup-to-all-zero-address-crash-log.txt

[Radar WebKit Bug Importer]

<rdar://problem/130993689>

[Anfernee Viduya]

Pull request: https://github.com/WebKit/WebKit/pull/30406

[EWS]

Test gardening commit 280593@main (fbae0ab6ba5d): <https://commits.webkit.org/280593@main>

Reviewed commits have been landed. Closing PR #30406 and removing active labels.

[Anfernee Viduya]

I have chosen to Skip the test in wk1 debug.

[Karl Dubost]

Should this be closed?

[Alexey Proskuryakov]

No, the test still needs to be fixed.

This assertion is (pretty accurately) saying that one cannot use window.open is a test that's not async. Unfortunate that WK2 doesn't appear to catch that.